Re: [spp] [PATCH] spp_vf: change char length to avoid compile error

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/16/2018 7:07 AM, Yasufumi Ogawa wrote:
> On 2018/04/16 11:26, Kenta Shinohara wrote:
>> Change character length of SPP_CMD_VALUE_BUFSZ to avoid compile error
>> on gcc-7.
>>
>> Signed-off-by: Kenta Shinohara <shinohara.kenta@lab.ntt.co.jp>
> Hi Kenta,
> 
> Thank you for your contribution!
> 
> I also tried to compile met the same problem on Ubuntu 17.10 and gcc ver 7.1. It seems that checking is more strict in gcc ver 
> 7.1 while ver 5.4 on Ubuntu 16.04 LTS. Your patch is working on both of Ubuntu16.04 and 17.10.
> 
> spp/src/vf/command_proc.c:231:37: error: ‘%s’ directive writing up to 127 bytes into a region of size 112 [-Werror=format-overflow=]
>     sprintf(message, "unknown command(%s)", decode_error->value);
>                                       ^~    ~~~~~~~~~~~~
> In file included from /usr/include/stdio.h:862:0,
>                   from /home/ubuntu/dpdk-home/dpdk/x86_64-native-linuxapp-gcc/include/rte_log.h:50,
>                   from /home/ubuntu/dpdk-home/spp/src/vf/command_proc.c:4:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: ‘__builtin___sprintf_chk’ output between 18 and 145 bytes into a 
> destination of size 128
>     return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>         __bos (__s), __fmt, __va_arg_pack ());
>         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I think it is acceptable to change buf size from 128 to 111 because command is not so long to exceed over 100 chars in spp_vf.
> 
> Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Applied, thanks.

(The build error and comment to change buf size to 111 added to commit log)