From: Ferruh Yigit <ferruh.yigit@intel.com>
To: ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org
Cc: gerald.rogers@intel.com, sy.jong.choi@intel.com
Subject: Re: [spp] [PATCH 1/7] spp_nfv: change type of port_id to uint16_t
Date: Thu, 7 Dec 2017 10:08:39 -0800 [thread overview]
Message-ID: <0dda52f4-40b2-26a0-6ee4-c18fcc97ce14@intel.com> (raw)
In-Reply-To: <20171206081826.67688-1-ogawa.yasufumi@lab.ntt.co.jp>
On 12/6/2017 12:18 AM, ogawa.yasufumi@lab.ntt.co.jp wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>
> In SPP, type of port_id is int while it is changed from uint8_t to
> uint16_t in DPDK 17.11. It causes compile errors for incompatible
> pointer type.
>
> In addition, SPP expects negative value of port_id if it is
> unassigned or invalid case. It is also a problem because comparing
> uint16_t with negative value is not allowed.
>
> This update is to change type of port_id and its validation. PORT_RESET
> used for unassigned ports is changed from -99 to UINT16_MAX to avoid
> negative value.
>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Series applied, thanks.
prev parent reply other threads:[~2017-12-07 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 8:18 ogawa.yasufumi
2017-12-06 8:18 ` [spp] [PATCH 2/7] spp_vm: " ogawa.yasufumi
2017-12-06 8:18 ` [spp] [PATCH 3/7] spp_primary: change type of ports_id " ogawa.yasufumi
2017-12-06 8:18 ` [spp] [PATCH 4/7] spp_vm: " ogawa.yasufumi
2017-12-06 8:18 ` [spp] [PATCH 5/7] spp/shared: " ogawa.yasufumi
2017-12-06 8:18 ` [spp] [PATCH 6/7] spp: change type of counter " ogawa.yasufumi
2017-12-06 8:18 ` [spp] [PATCH 7/7] spp/shared: refactor printing port status ogawa.yasufumi
2017-12-07 18:08 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dda52f4-40b2-26a0-6ee4-c18fcc97ce14@intel.com \
--to=ferruh.yigit@intel.com \
--cc=gerald.rogers@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
--cc=sy.jong.choi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).