From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3313329CA for ; Thu, 7 Dec 2017 19:08:40 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 10:08:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,373,1508828400"; d="scan'208";a="9967612" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.165]) ([10.241.225.165]) by FMSMGA003.fm.intel.com with ESMTP; 07 Dec 2017 10:08:39 -0800 To: ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org Cc: gerald.rogers@intel.com, sy.jong.choi@intel.com References: <20171206081826.67688-1-ogawa.yasufumi@lab.ntt.co.jp> From: Ferruh Yigit Message-ID: <0dda52f4-40b2-26a0-6ee4-c18fcc97ce14@intel.com> Date: Thu, 7 Dec 2017 10:08:39 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171206081826.67688-1-ogawa.yasufumi@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH 1/7] spp_nfv: change type of port_id to uint16_t X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 18:08:41 -0000 On 12/6/2017 12:18 AM, ogawa.yasufumi@lab.ntt.co.jp wrote: > From: Yasufumi Ogawa > > In SPP, type of port_id is int while it is changed from uint8_t to > uint16_t in DPDK 17.11. It causes compile errors for incompatible > pointer type. > > In addition, SPP expects negative value of port_id if it is > unassigned or invalid case. It is also a problem because comparing > uint16_t with negative value is not allowed. > > This update is to change type of port_id and its validation. PORT_RESET > used for unassigned ports is changed from -99 to UINT16_MAX to avoid > negative value. > > Signed-off-by: Yasufumi Ogawa Series applied, thanks.