From: Yasufumi Ogawa <geminoa@juno.ocn.ne.jp>
To: x-fn-spp@sl.ntt-tx.co.jp
Cc: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org
Subject: Re: [spp] [PATCH v2 0/6] Replace deprecated APIs
Date: Sat, 24 Nov 2018 21:57:36 +0900 [thread overview]
Message-ID: <10f6777b-9af0-9705-bed4-054e7fd9a8ac@juno.ocn.ne.jp> (raw)
In-Reply-To: <201811210652.wAL6qKRn011045@imss04.silk.ntt-tx.co.jp>
>>From DPDK 18.08, following APIs become deprecated and will be deleted in 18.11.
> - rte_eth_dev_attach()
> - rte_eth_dev_detach()
>
> It is recommended to use followings.
> - rte_eth_dev_attach() should be replaced by rte_eal_hotplug_add().
> - rte_eth_dev_detach() should be replaced by rte_eal_hotplug_remove().
>
> This series of patches is to update for the changes.
> - Add dev_attach_by_devargs() as replacement of rte_eth_dev_attach(). This function
> calls rte_eal_hotplug_add() to hotplug device for given name "devargs",and returns
> newly allocated dpdk port_id.
> - Add dev_detach_by_port_id() as replacement of rte_eth_dev_detach(). This function
> calls rte_eal_hotplug_remove() to detach device for given port_id.
> - Replace rte_eth_dev_attach() in spp_nfv and spp_vf with dev_attach_by_devargs().
> - Replace rte_eth_dev_attach() in spp_nfv and spp_vf with dev_detach_by_port_id().
Hideyuki,
Your patches cause compile errors because DPDK APIs you use instead of
depricated APIs are still not stable. You should add
`-DALLOW_EXPERIMENTAL_API` to CFLAG option in each of Makefiles of SPP
processes.
I already fixed this bug while I checked your patches. I would like to
send patches to fix this bug.
Thanks,
Yasufumi
>
> Hideyuki Yamashita (6):
> shared: add dev_attach_by_devargs
> spp_nfv: replace deprecated rte_eth_dev_attach
> spp_vf: replace deprecated rte_eth_dev_attach
> shared: add dev_detach_by_port_id
> spp_nfv: replace deprecated rte_eth_dev_detach
> spp_vm: replace deprecated rte_eth_dev_detach
>
> src/nfv/nfv.c | 18 +++++--------
> src/shared/common.c | 64 +++++++++++++++++++++++++++++++++++++++++++++
> src/shared/common.h | 29 ++++++++++++++++++++
> src/vf/spp_vf.c | 4 +--
> src/vm/main.c | 4 +--
> 5 files changed, 102 insertions(+), 17 deletions(-)
>
next prev parent reply other threads:[~2018-11-24 12:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 5:07 [spp] [PATCH " x-fn-spp
2018-11-09 3:34 ` Yasufumi Ogawa
2018-11-09 9:22 ` [spp] [spp 03539] " Hideyuki Yamashita
2018-11-12 11:15 ` Yasufumi Ogawa
2018-11-13 0:27 ` Hideyuki Yamashita
2018-11-13 8:22 ` Yasufumi Ogawa
2018-11-14 0:40 ` Hideyuki Yamashita
2018-11-15 0:16 ` Nakamura Hioryuki
2018-11-15 14:17 ` Yasufumi Ogawa
2018-11-21 6:52 ` [spp] [PATCH v2 " x-fn-spp
2018-11-24 12:57 ` Yasufumi Ogawa [this message]
2018-11-28 2:44 ` Yasufumi Ogawa
2018-11-21 6:52 ` [spp] [PATCH v2 1/6] shared: add dev_attach_by_devargs x-fn-spp
2018-11-24 14:54 ` Yasufumi Ogawa
2018-11-26 4:12 ` [spp] [spp 03664] " Hideyuki Yamashita
2018-11-21 6:52 ` [spp] [PATCH v2 2/6] spp_nfv: replace deprecated rte_eth_dev_attach x-fn-spp
2018-11-21 6:52 ` [spp] [PATCH v2 3/6] spp_vf: " x-fn-spp
2018-11-21 6:52 ` [spp] [PATCH v2 4/6] shared: add dev_detach_by_port_id x-fn-spp
2018-11-24 15:02 ` Yasufumi Ogawa
2018-11-21 6:52 ` [spp] [PATCH v2 5/6] spp_nfv: replace deprecated rte_eth_dev_detach x-fn-spp
2018-11-21 6:52 ` [spp] [PATCH v2 6/6] spp_vm: " x-fn-spp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f6777b-9af0-9705-bed4-054e7fd9a8ac@juno.ocn.ne.jp \
--to=geminoa@juno.ocn.ne.jp \
--cc=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).