From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B130516E for ; Thu, 6 Jul 2017 14:57:04 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 05:57:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,317,1496127600"; d="scan'208";a="105127260" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 06 Jul 2017 05:56:59 -0700 To: Yasufumi Ogawa , sy.jong.choi@intel.com, spp@dpdk.org References: <894235f1-d439-8db2-73ab-55b16a474084@lab.ntt.co.jp> From: Ferruh Yigit Message-ID: <1339a006-43f6-8fa9-73a7-c8206d51d691@intel.com> Date: Thu, 6 Jul 2017 13:56:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <894235f1-d439-8db2-73ab-55b16a474084@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [spp] Proposal for adding port for external management tools X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 12:57:05 -0000 On 6/29/2017 10:16 AM, Yasufumi Ogawa wrote: > Hi, everyone, > > SPP controller is a CLI tool and has no way to send a command from > remote. Considering to control SPP from a management tool like an > orchestrator, it should be needed to have another port. This patch is > adding it (called management port) to SPP for the purpose. > > This patch also includes following bug fixes. > - Remove unwanted spaces from the sec command to avoid parse error. > - Add socket.SO_REUSEADDR option for avoiding 'port is already used'. > - Correct command completion. > - Fix errors in report/playback command. Hi Yasufumi, Thank you for the patch. I think adding a remote management port is good idea. But I am not able to apply the patch, mail client seems wrapped some lines, I tried to fix but not able to. Would you mind using git send-email for sending patches? And if possible can you please split patch into multiple patches, one patch for each logical thing, for your case you can have a separate patch for each fix you listed above. This makes easy to understand each modification done for a fix or feature. Thanks, ferruh > > Regards, > > Yasufumi >