Re: [spp] [PATCH] spp_vf: fix build

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/30/2018 3:55 AM, Yasufumi Ogawa wrote:
> On 2018/01/22 23:25, Ferruh Yigit wrote:
>> build error:
>> ...spp/src/vf/classifier_mac.c:314:5:
>>     error: format specifies type 'unsigned short' but the argument
>>            has type 'int' [-Werror,-Wformat]
>> 	classified_data->num_pkt - n_tx, classified_data->port);
>> 	^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ...build/include/rte_log.h:316:32:
>>     note: expanded from macro 'RTE_LOG'
>> 	 RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
>> 				     ^~~~~~~~~~~
>>
>> Looks like caused by integer promotion, to fix cast variable
>> explicityly to uint16_t.
> 
> Ferruh,
> 
> Thanks for your contribution. Although I compiled Hiroyuki's patch with 
> DPDK 17.11 release (tagged as v17.11) and there is no error, but error 
> is occured after replacing DPDK latest.
> 
> ...spp/src/vf/spp_vf.c:931:28: error: ‘RTE_LOG_LEVEL’ undeclared (first 
> use in this function)
>     rte_log_set_global_level(RTE_LOG_LEVEL);
> 
> ...spp/src/vf/spp_vf.c:931:28: note: each undeclared identifier is 
> reported only once for each function it appears in
> /home/dpdk1711/dpdk-home/dpdk/mk/internal/rte.compile-pre.mk:114: ...
> 
> It is different from your error, but caused by rte_log. I think it is 
> possibly because of a change of rte_log after 17.11 release. In any 
> case, I think your change should be merged.
> 
> Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Applied, thanks.