From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DE9622BBB for ; Thu, 1 Feb 2018 13:01:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 04:01:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,444,1511856000"; d="scan'208";a="14565923" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.157]) ([10.237.220.157]) by fmsmga007.fm.intel.com with ESMTP; 01 Feb 2018 04:01:30 -0800 To: Yasufumi Ogawa Cc: spp@dpdk.org, nakamura.hioryuki@po.ntt-tx.co.jp References: <20180122142537.20291-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <150f2123-5520-1786-1830-5b2d68069bff@intel.com> Date: Thu, 1 Feb 2018 12:01:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [spp] [PATCH] spp_vf: fix build X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 12:01:33 -0000 On 1/30/2018 3:55 AM, Yasufumi Ogawa wrote: > On 2018/01/22 23:25, Ferruh Yigit wrote: >> build error: >> ...spp/src/vf/classifier_mac.c:314:5: >> error: format specifies type 'unsigned short' but the argument >> has type 'int' [-Werror,-Wformat] >> classified_data->num_pkt - n_tx, classified_data->port); >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> ...build/include/rte_log.h:316:32: >> note: expanded from macro 'RTE_LOG' >> RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) >> ^~~~~~~~~~~ >> >> Looks like caused by integer promotion, to fix cast variable >> explicityly to uint16_t. > > Ferruh, > > Thanks for your contribution. Although I compiled Hiroyuki's patch with > DPDK 17.11 release (tagged as v17.11) and there is no error, but error > is occured after replacing DPDK latest. > > ...spp/src/vf/spp_vf.c:931:28: error: ‘RTE_LOG_LEVEL’ undeclared (first > use in this function) > rte_log_set_global_level(RTE_LOG_LEVEL); > > ...spp/src/vf/spp_vf.c:931:28: note: each undeclared identifier is > reported only once for each function it appears in > /home/dpdk1711/dpdk-home/dpdk/mk/internal/rte.compile-pre.mk:114: ... > > It is different from your error, but caused by rte_log. I think it is > possibly because of a change of rte_log after 17.11 release. In any > case, I think your change should be merged. > > Acked-by: Yasufumi Ogawa Applied, thanks.