From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com
Cc: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Subject: [spp] [PATCH 2/9] shared: update print_active_ports
Date: Mon, 12 Mar 2018 14:35:17 +0900 [thread overview]
Message-ID: <1520832924-28387-3-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1520832924-28387-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To comply with change displaying status, update the message format
defined in print_active_ports() in secondary process.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/shared/common.c | 71 ++++++++++++++++++++++++++++++++++++++++-------------
src/shared/common.h | 2 +-
2 files changed, 55 insertions(+), 18 deletions(-)
diff --git a/src/shared/common.c b/src/shared/common.c
index 4176b6d..1ef63de 100644
--- a/src/shared/common.c
+++ b/src/shared/common.c
@@ -258,15 +258,14 @@ spp_atoi(const char *str, int *val)
* "port_id:[PORT_ID],[IN_PORT_STAT],[TYPE],output:[OUTPORT_STAT]"
*/
void
-print_active_ports(char *str, uint16_t client_id,
+print_active_ports(char *str,
struct port *ports_fwd_array,
struct port_map *port_map)
{
unsigned int i;
- sprintf(str, "clinet_id:%d\n", client_id);
-
/* Every elements value */
+ sprintf(str, "ports: ");
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
if (ports_fwd_array[i].in_port_id == PORT_RESET)
continue;
@@ -275,51 +274,89 @@ print_active_ports(char *str, uint16_t client_id,
RTE_LOG(INFO, APP, "Status %d\n",
ports_fwd_array[i].in_port_id);
- sprintf(str + strlen(str), "port_id:%d,", i);
/* in_port_id is same value as port_id */
- if (ports_fwd_array[i].in_port_id != PORT_RESET)
- sprintf(str + strlen(str), "on,");
- else
- sprintf(str + strlen(str), "off,");
+ /**
+ * NOTE(yasuufm)
+ * in_port_id cannot be PORT_RESET currently and it is
+ * meaningless, but not remove for future possible change
+ */
+ // if (ports_fwd_array[i].in_port_id != PORT_RESET)
+ // sprintf(str + strlen(str), "on,");
+ // else
+ // sprintf(str + strlen(str), "off,");
switch (port_map[i].port_type) {
case PHY:
RTE_LOG(INFO, APP, "Type: PHY\n");
- sprintf(str + strlen(str), "PHY,");
+ sprintf(str + strlen(str), "phy:%u-",
+ port_map[i].id);
break;
case RING:
RTE_LOG(INFO, APP, "Type: RING\n");
- sprintf(str + strlen(str), "RING(%u),",
+ sprintf(str + strlen(str), "ring:%u-",
port_map[i].id);
break;
case VHOST:
RTE_LOG(INFO, APP, "Type: VHOST\n");
- sprintf(str + strlen(str), "VHOST(%u),",
+ sprintf(str + strlen(str), "vhost:%u-",
port_map[i].id);
break;
case PCAP:
RTE_LOG(INFO, APP, "Type: PCAP\n");
- sprintf(str + strlen(str), "PCAP(%u),",
+ sprintf(str + strlen(str), "pcap:%u-",
port_map[i].id);
break;
case NULLPMD:
RTE_LOG(INFO, APP, "Type: NULLPMD\n");
- sprintf(str + strlen(str), "NULLPMD(%u),",
+ sprintf(str + strlen(str), "nullpmd:%u-",
port_map[i].id);
break;
case UNDEF:
RTE_LOG(INFO, APP, "Type: UDF\n");
- sprintf(str + strlen(str), "UDF,");
+ /* TODO(yasufum) remove print for undefined ? */
+ sprintf(str + strlen(str), "udf-");
break;
}
RTE_LOG(INFO, APP, "Out Port ID %d\n",
ports_fwd_array[i].out_port_id);
if (ports_fwd_array[i].out_port_id == PORT_RESET) {
- sprintf(str + strlen(str), "outport:%s\n", "none");
+ sprintf(str + strlen(str), "%s", "null,");
} else {
- sprintf(str + strlen(str), "outport:%d\n",
- ports_fwd_array[i].out_port_id);
+ unsigned int j = ports_fwd_array[i].out_port_id;
+ switch (port_map[j].port_type) {
+ case PHY:
+ RTE_LOG(INFO, APP, "Type: PHY\n");
+ sprintf(str + strlen(str), "phy:%u,",
+ port_map[j].id);
+ break;
+ case RING:
+ RTE_LOG(INFO, APP, "Type: RING\n");
+ sprintf(str + strlen(str), "ring:%u,",
+ port_map[j].id);
+ break;
+ case VHOST:
+ RTE_LOG(INFO, APP, "Type: VHOST\n");
+ sprintf(str + strlen(str), "vhost:%u,",
+ port_map[j].id);
+ break;
+ case PCAP:
+ RTE_LOG(INFO, APP, "Type: PCAP\n");
+ sprintf(str + strlen(str), "pcap:%u,",
+ port_map[j].id);
+ break;
+ case NULLPMD:
+ RTE_LOG(INFO, APP, "Type: NULLPMD\n");
+ sprintf(str + strlen(str), "nullpmd:%u,",
+ port_map[j].id);
+ break;
+ case UNDEF:
+ RTE_LOG(INFO, APP, "Type: UDF\n");
+ /* TODO(yasufum) remove print for undefined ? */
+ sprintf(str + strlen(str), "udf,");
+ break;
+ }
}
}
+ sprintf(str + strlen(str) - 1, "%c", '\0');
}
diff --git a/src/shared/common.h b/src/shared/common.h
index f0d68e5..2dc31c9 100644
--- a/src/shared/common.h
+++ b/src/shared/common.h
@@ -216,7 +216,7 @@ int parse_portmask(struct port_info *ports, uint16_t max_ports,
int parse_num_clients(uint16_t *num_clients, const char *clients);
int parse_server(char **server_ip, int *server_port, char *server_addr);
-void print_active_ports(char *str, uint16_t client_id,
+void print_active_ports(char *str,
struct port *ports_fwd_array,
struct port_map *port_map);
--
2.7.4
next prev parent reply other threads:[~2018-03-12 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 9:28 [spp] Port ID incrementation is changed from DPDK18.02 Yasufumi Ogawa
2018-03-12 5:35 ` [spp] [PATCH 0/9] Update port management ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 1/9] controller: change displaying status ogawa.yasufumi
2018-03-12 5:35 ` ogawa.yasufumi [this message]
2018-03-12 5:35 ` [spp] [PATCH 3/9] spp_nfv: change format " ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 4/9] spp_vm: " ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 5/9] controller: add delimiter for topo command ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 6/9] controller: update Shell for topo_subgraph ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 7/9] controller: update generating graph ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 8/9] controller: update topo command ogawa.yasufumi
2018-03-12 5:35 ` [spp] [PATCH 9/9] shared: fix bug for print port status ogawa.yasufumi
2018-03-27 23:51 ` [spp] [PATCH 0/9] Update port management Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520832924-28387-3-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).