Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com
Cc: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Subject: [spp] [PATCH 5/9] controller: add delimiter for topo command
Date: Mon, 12 Mar 2018 14:35:20 +0900	[thread overview]
Message-ID: <1520832924-28387-6-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1520832924-28387-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Resource ID consists of resource type and ID separated with
delimiter ':', for instance, 'phy:0'. This delimiter causes a parse
error in topo command because graphviz does not support ':' as a valid
character for node ID. If ':' is included in node ID, graphviz outputs
an imcomplete graph.

To avoid this problem, replace ':' with other valid character for node
IDs while labels displayed in the graph are not replaced.

This update add definitions for charactors of delimiter and label in
'spp_common.py'. Delimiter ':' is replaced with label charactor '_'
while graphviz script is generated.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/controller/spp_common.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/controller/spp_common.py b/src/controller/spp_common.py
index 59ba504..b1ab60f 100644
--- a/src/controller/spp_common.py
+++ b/src/controller/spp_common.py
@@ -33,6 +33,9 @@ REMOTE_COMMAND = "RCMD"
 RCMD_EXECUTE_QUEUE = Queue()
 RCMD_RESULT_QUEUE = Queue()
 
+delim_node = '_'
+delim_label = ':'
+
 
 class GrowingList(list):
     """Growing List
-- 
2.7.4

  parent reply	other threads:[~2018-03-12  5:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01  9:28 [spp] Port ID incrementation is changed from DPDK18.02 Yasufumi Ogawa
2018-03-12  5:35 ` [spp] [PATCH 0/9] Update port management ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 1/9] controller: change displaying status ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 2/9] shared: update print_active_ports ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 3/9] spp_nfv: change format displaying status ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 4/9] spp_vm: " ogawa.yasufumi
2018-03-12  5:35   ` ogawa.yasufumi [this message]
2018-03-12  5:35   ` [spp] [PATCH 6/9] controller: update Shell for topo_subgraph ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 7/9] controller: update generating graph ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 8/9] controller: update topo command ogawa.yasufumi
2018-03-12  5:35   ` [spp] [PATCH 9/9] shared: fix bug for print port status ogawa.yasufumi
2018-03-27 23:51   ` [spp] [PATCH 0/9] Update port management Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520832924-28387-6-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).