From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH] spp_pcap: fix inappropriate linking of liblz4
Date: Tue, 12 Mar 2019 18:11:20 +0900 [thread overview]
Message-ID: <1552381880-891-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
In Makefile of spp_pcap, `liblz4.a` is linked directly as other source
codes. However, file path might be different on other distros, such as
CentOS or Fedora.
SRCS-y += /usr/lib/x86_64-linux-gnu/liblz4.a
This update is to correct to link this library with `-l` option as
practical manner.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/pcap/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/pcap/Makefile b/src/pcap/Makefile
index 298e2b7..199a8ff 100644
--- a/src/pcap/Makefile
+++ b/src/pcap/Makefile
@@ -18,7 +18,6 @@ SRCS-y += command_proc.c command_dec.c
SRCS-y += ../shared/common.c
SRCS-y += ../vf/common/command_conn.c ../vf/common/spp_port.c
SRCS-y += ../vf/common/ringlatencystats.c ../vf/common/string_buffer.c
-SRCS-y += /usr/lib/x86_64-linux-gnu/liblz4.a
CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += $(WERROR_FLAGS) -O3 -MMD
@@ -28,6 +27,8 @@ CFLAGS += -I$(SRCDIR)/../shared
#CFLAGS += -DSPP_DEMONIZE
#CFLAGS += -DSPP_RINGLATENCYSTATS_ENABLE
+LDLIBS += -llz4
+
ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
LDLIBS += -lrte_pmd_ring
LDLIBS += -lrte_pmd_vhost
--
2.7.4
reply other threads:[~2019-03-12 9:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552381880-891-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).