From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 0/4] Move vf/common to under shared directory
Date: Wed, 8 May 2019 11:00:02 +0900 [thread overview]
Message-ID: <1557280806-7672-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Spp_vf and its siblings use common libs `srv/vf/common`. However, it is
not good design considering conventions, but should be placed
`src/shared` in the case of SPP. In addition, codes of spp_vf siblings
are not neat and tightly coupled and many of functions in `vf/common`
uses spp_vf siblings and vice versa.
This series of patches is to fix the issue by moving common libs to
under `src/shared` and remove dependency referring from common
functions to each of siblings. However, some of functions used specific
sibling, which are not common actually, are still remained as
`src/shared/secondary/spp_worker_th/vf_deps.h`
because of too much complexity of data structure and functions. This
`vf_deps.h` is released in next update, but will be removed from shared
dir in a future update for refactoring.
Yasufumi Ogawa (4):
spp_vf: move common of vf siblings to shared dir
spp_vf: update makefile for moved common files
spp_vf: update include paths
spp_vf: remove dependency from common functions
.../secondary/spp_worker_th}/command_conn.c | 0
.../secondary/spp_worker_th}/command_conn.h | 0
.../secondary/spp_worker_th}/command_dec.c | 0
.../secondary/spp_worker_th}/command_dec.h | 0
.../secondary/spp_worker_th}/command_proc.c | 37 +++++-
.../secondary/spp_worker_th}/command_proc.h | 0
.../spp_worker_th}/ringlatencystats.c | 0
.../spp_worker_th}/ringlatencystats.h | 0
.../secondary/spp_worker_th}/spp_port.c | 0
.../secondary/spp_worker_th}/spp_port.h | 0
.../secondary/spp_worker_th}/spp_proc.c | 5 +-
.../secondary/spp_worker_th}/spp_proc.h | 0
.../secondary/spp_worker_th}/string_buffer.c | 0
.../secondary/spp_worker_th}/string_buffer.h | 0
src/vf/Makefile | 15 ++-
src/vf/classifier_mac.c | 121 +-----------------
src/vf/classifier_mac.h | 32 -----
src/vf/spp_forward.c | 3 +-
src/vf/spp_forward.h | 30 -----
src/vf/spp_vf.c | 8 +-
20 files changed, 54 insertions(+), 197 deletions(-)
rename src/{vf/common => shared/secondary/spp_worker_th}/command_conn.c (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/command_conn.h (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/command_dec.c (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/command_dec.h (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/command_proc.c (98%)
rename src/{vf/common => shared/secondary/spp_worker_th}/command_proc.h (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/ringlatencystats.c (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/ringlatencystats.h (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/spp_port.c (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/spp_port.h (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/spp_proc.c (99%)
rename src/{vf/common => shared/secondary/spp_worker_th}/spp_proc.h (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/string_buffer.c (100%)
rename src/{vf/common => shared/secondary/spp_worker_th}/string_buffer.h (100%)
--
2.17.1
next reply other threads:[~2019-05-08 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 2:00 ogawa.yasufumi [this message]
2019-05-08 2:00 ` [spp] [PATCH 1/4] spp_vf: move common of vf siblings to shared dir ogawa.yasufumi
2019-05-08 2:00 ` [spp] [PATCH 2/4] spp_vf: update makefile for moved common files ogawa.yasufumi
2019-05-08 2:00 ` [spp] [PATCH 3/4] spp_vf: update include paths ogawa.yasufumi
2019-05-08 2:00 ` [spp] [PATCH 4/4] spp_vf: remove dependency from common functions ogawa.yasufumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557280806-7672-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).