From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 12/17] shared/sec: change struct of comp command
Date: Wed, 8 May 2019 11:01:30 +0900 [thread overview]
Message-ID: <1557280895-7978-13-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1557280895-7978-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
For refactoring, change the name of struct `spp_command_component` to
`sppwk_cmd_comp`.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/shared/secondary/spp_worker_th/cmd_parser.h | 4 ++--
src/shared/secondary/spp_worker_th/command_dec.c | 14 +++++++-------
src/shared/secondary/spp_worker_th/command_proc.c | 8 ++++----
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.h b/src/shared/secondary/spp_worker_th/cmd_parser.h
index 04f9f75..669f199 100644
--- a/src/shared/secondary/spp_worker_th/cmd_parser.h
+++ b/src/shared/secondary/spp_worker_th/cmd_parser.h
@@ -87,7 +87,7 @@ struct sppwk_cmd_flush {
};
/* `component` command parameters. */
-struct spp_command_component {
+struct sppwk_cmd_comp {
enum sppwk_action wk_action; /**< start or stop */
char name[SPPWK_NAME_BUFSZ]; /**< component name */
unsigned int core; /**< logical core number */
@@ -109,7 +109,7 @@ struct spp_command {
union { /**< command descriptors */
struct sppwk_cls_cmd_attr cls_table;
struct sppwk_cmd_flush flush;
- struct spp_command_component component;
+ struct sppwk_cmd_comp comp;
struct spp_command_port port;
} spec;
};
diff --git a/src/shared/secondary/spp_worker_th/command_dec.c b/src/shared/secondary/spp_worker_th/command_dec.c
index 9904ad8..493d9cb 100644
--- a/src/shared/secondary/spp_worker_th/command_dec.c
+++ b/src/shared/secondary/spp_worker_th/command_dec.c
@@ -372,7 +372,7 @@ decode_component_name_value(void *output, const char *arg_val,
int allow_override __attribute__ ((unused)))
{
int ret = SPP_RET_OK;
- struct spp_command_component *component = output;
+ struct sppwk_cmd_comp *component = output;
/* "stop" has no core ID parameter. */
if (component->wk_action == SPPWK_ACT_START) {
@@ -393,7 +393,7 @@ static int
decode_component_core_value(void *output, const char *arg_val,
int allow_override __attribute__ ((unused)))
{
- struct spp_command_component *component = output;
+ struct sppwk_cmd_comp *component = output;
/* "stop" has no core ID parameter. */
if (component->wk_action != SPPWK_ACT_START)
@@ -408,7 +408,7 @@ decode_component_type_value(void *output, const char *arg_val,
int allow_override __attribute__ ((unused)))
{
enum spp_component_type comp_type;
- struct spp_command_component *component = output;
+ struct sppwk_cmd_comp *component = output;
/* "stop" has no type parameter. */
if (component->wk_action != SPPWK_ACT_START)
@@ -831,22 +831,22 @@ parameter_list[][SPPWK_MAX_PARAMS] = {
{
.name = "action",
.offset = offsetof(struct spp_command,
- spec.component.wk_action),
+ spec.comp.wk_action),
.func = decode_component_action_value
},
{
.name = "component name",
- .offset = offsetof(struct spp_command, spec.component),
+ .offset = offsetof(struct spp_command, spec.comp),
.func = decode_component_name_value
},
{
.name = "core",
- .offset = offsetof(struct spp_command, spec.component),
+ .offset = offsetof(struct spp_command, spec.comp),
.func = decode_component_core_value
},
{
.name = "component type",
- .offset = offsetof(struct spp_command, spec.component),
+ .offset = offsetof(struct spp_command, spec.comp),
.func = decode_component_type_value
},
DECODE_PARAMETER_LIST_EMPTY,
diff --git a/src/shared/secondary/spp_worker_th/command_proc.c b/src/shared/secondary/spp_worker_th/command_proc.c
index c5b1273..3e8c52a 100644
--- a/src/shared/secondary/spp_worker_th/command_proc.c
+++ b/src/shared/secondary/spp_worker_th/command_proc.c
@@ -760,10 +760,10 @@ execute_command(const struct spp_command *command)
RTE_LOG(INFO, SPP_COMMAND_PROC,
"Execute component command.\n");
ret = spp_update_component(
- command->spec.component.wk_action,
- command->spec.component.name,
- command->spec.component.core,
- command->spec.component.type);
+ command->spec.comp.wk_action,
+ command->spec.comp.name,
+ command->spec.comp.core,
+ command->spec.comp.type);
if (ret == 0) {
RTE_LOG(INFO, SPP_COMMAND_PROC,
"Execute flush.\n");
--
2.17.1
next prev parent reply other threads:[~2019-05-08 2:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 2:01 [spp] [PATCH 00/17] Refactor command parser of SPP worker ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 01/17] shared/sec: change prefix of common functions ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 02/17] shared/sec: refactor parse error code ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 03/17] shared/sec: revice cmd parser of SPP worker ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 04/17] shared/sec: refactor branching for cmd action ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 05/17] shared/sec: rename define starts from SPP_CMD_MAX ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 06/17] shared/sec: rename define of buffer size for cmds ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 07/17] shared/sec: remove unused define of cmd parser ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 08/17] shared/sec: refactor commad type of SPP worker ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 09/17] shared/sec: change struct of classier table attrs ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 10/17] shared/sec: refactor function parsing cls port ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 11/17] shared/sec: rename func of flush command ogawa.yasufumi
2019-05-08 2:01 ` ogawa.yasufumi [this message]
2019-05-08 2:01 ` [spp] [PATCH 13/17] shared/sec: revise port info of SPP worker ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 14/17] shared/sec: rename func for getting port ID ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 15/17] shared/sec: rename dpdk_port attr ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 16/17] shared/sec: rename struct for command request ogawa.yasufumi
2019-05-08 2:01 ` [spp] [PATCH 17/17] shared/sec: rename func for parsing request ogawa.yasufumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557280895-7978-13-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).