From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ADF25A05D3 for ; Tue, 21 May 2019 04:34:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A16994CA6; Tue, 21 May 2019 04:34:12 +0200 (CEST) Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 1454914EC for ; Tue, 21 May 2019 04:34:09 +0200 (CEST) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x4L2Y8r6003188; Tue, 21 May 2019 11:34:08 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id A8AA26389FB; Tue, 21 May 2019 11:34:08 +0900 (JST) Received: from localhost.localdomain (lobster.nslab.ecl.ntt.co.jp [129.60.13.95]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 9858263874A; Tue, 21 May 2019 11:34:08 +0900 (JST) From: ogawa.yasufumi@lab.ntt.co.jp To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Date: Tue, 21 May 2019 11:31:41 +0900 Message-Id: <1558405903-8252-3-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1558405903-8252-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> References: <1558405903-8252-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-TM-AS-MML: disable Subject: [spp] [PATCH 2/4] shared/sec: rename struct of cmd operators X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa A set of operators and its names for parsing command is defined as `decode_parameter_list`, but the name is inappropriate considering the purpose. This update is to rename it to `sppwk_cmd_ops` instead. Signed-off-by: Yasufumi Ogawa --- .../secondary/spp_worker_th/cmd_parser.c | 36 +++++++++---------- .../secondary/spp_worker_th/cmd_parser.h | 2 +- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c index 6122cee..853b0ab 100644 --- a/src/shared/secondary/spp_worker_th/cmd_parser.c +++ b/src/shared/secondary/spp_worker_th/cmd_parser.c @@ -659,7 +659,7 @@ decode_classifier_vid_value(void *output, const char *arg_val, return SPP_RET_OK; } -/* decoding procedure of port for classifier_table command */ +/* Parse port for classifier_table command */ static int parse_cls_port(void *cls_cmd_attr, const char *arg_val, int allow_override __attribute__ ((unused))) @@ -710,20 +710,20 @@ parse_cls_port(void *cls_cmd_attr, const char *arg_val, return SPP_RET_OK; } -/* parameter list for decoding */ -struct decode_parameter_list { - const char *name; /* Parameter name */ - size_t offset; /* Offset value of struct spp_command */ +/* Attributes operator functions of command for parsing. */ +struct sppwk_cmd_ops { + const char *name; + size_t offset; /* Offset of struct spp_command */ + /* Pointer to operator function */ int (*func)(void *output, const char *arg_val, int allow_override); - /* Pointer to parameter handling function */ }; /* Used for command which takes no params, such as `status`. */ #define SPPWK_CMD_NO_PARAMS { NULL, 0, NULL } -/* parameter list for each command */ -static struct decode_parameter_list -parameter_list[][SPPWK_MAX_PARAMS] = { +/* A set of operator functions for parsing command. */ +static struct sppwk_cmd_ops +cmd_ops_list[][SPPWK_MAX_PARAMS] = { { /* classifier_table(mac) */ { .name = "action", @@ -863,11 +863,11 @@ decode_command_parameter_component(struct sppwk_cmd_req *request, int ret = SPP_RET_OK; int ci = request->commands[0].type; int pi = 0; - struct decode_parameter_list *list = NULL; + struct sppwk_cmd_ops *list = NULL; for (pi = 1; pi < argc; pi++) { - list = ¶meter_list[ci][pi-1]; + list = &cmd_ops_list[ci][pi-1]; ret = (*list->func)((void *) - ((char *)&request->commands[0]+list->offset), + ((char *)&request->commands[0] + list->offset), argv[pi], 0); if (unlikely(ret < 0)) { RTE_LOG(ERR, SPP_COMMAND_PROC, @@ -904,11 +904,11 @@ decode_command_parameter_cls_table_vlan(struct sppwk_cmd_req *request, int ret = SPP_RET_OK; int ci = request->commands[0].type; int pi = 0; - struct decode_parameter_list *list = NULL; + struct sppwk_cmd_ops *list = NULL; for (pi = 1; pi < argc; pi++) { - list = ¶meter_list[ci][pi-1]; + list = &cmd_ops_list[ci][pi-1]; ret = (*list->func)((void *) - ((char *)&request->commands[0]+list->offset), + ((char *)&request->commands[0] + list->offset), argv[pi], 0); if (unlikely(ret < SPP_RET_OK)) { RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad value. " @@ -931,7 +931,7 @@ decode_command_parameter_port(struct sppwk_cmd_req *request, int ret = SPP_RET_OK; int ci = request->commands[0].type; int pi = 0; - struct decode_parameter_list *list = NULL; + struct sppwk_cmd_ops *list = NULL; int flag = 0; /* check add vlatag */ @@ -939,9 +939,9 @@ decode_command_parameter_port(struct sppwk_cmd_req *request, flag = 1; for (pi = 1; pi < argc; pi++) { - list = ¶meter_list[ci][pi-1]; + list = &cmd_ops_list[ci][pi-1]; ret = (*list->func)((void *) - ((char *)&request->commands[0]+list->offset), + ((char *)&request->commands[0] + list->offset), argv[pi], flag); if (unlikely(ret < SPP_RET_OK)) { RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad value. " diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.h b/src/shared/secondary/spp_worker_th/cmd_parser.h index 58e39a9..286fde0 100644 --- a/src/shared/secondary/spp_worker_th/cmd_parser.h +++ b/src/shared/secondary/spp_worker_th/cmd_parser.h @@ -112,7 +112,7 @@ struct spp_command { struct sppwk_cmd_flush flush; struct sppwk_cmd_comp comp; struct sppwk_cmd_port port; - } spec; + } spec; /* TODO(yasufum) rename no reasonable name */ }; /* Request parameters. */ -- 2.17.1