Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 1/6] shared/sec: rename parse comp action val
Date: Tue, 21 May 2019 11:31:59 +0900	[thread overview]
Message-ID: <1558405924-8303-2-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1558405924-8303-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

The name `decode_component_action_value` is too long and not intuitive.
This update is to fix the issue by renaming to `parse_comp_action`.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/shared/secondary/spp_worker_th/cmd_parser.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c
index ae845f4..6fc3a51 100644
--- a/src/shared/secondary/spp_worker_th/cmd_parser.c
+++ b/src/shared/secondary/spp_worker_th/cmd_parser.c
@@ -299,10 +299,10 @@ parse_lcore_id(void *output, const char *arg_val)
 
 /* decoding procedure of action for component command */
 static int
-decode_component_action_value(void *output, const char *arg_val,
-				int allow_override __attribute__ ((unused)))
+parse_comp_action(void *output, const char *arg_val,
+		int allow_override __attribute__ ((unused)))
 {
-	int ret = SPP_RET_OK;
+	int ret;
 	ret = get_list_idx(arg_val, CMD_ACT_LIST);
 	if (unlikely(ret <= 0)) {
 		RTE_LOG(ERR, SPP_COMMAND_PROC,
@@ -797,7 +797,7 @@ cmd_ops_list[][SPPWK_MAX_PARAMS] = {
 			.name = "action",
 			.offset = offsetof(struct spp_command,
 					spec.comp.wk_action),
-			.func = decode_component_action_value
+			.func = parse_comp_action
 		},
 		{
 			.name = "component name",
-- 
2.17.1


  reply	other threads:[~2019-05-21  2:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  2:31 [spp] [PATCH 0/6] Revise name of funcs for parsing actions ogawa.yasufumi
2019-05-21  2:31 ` ogawa.yasufumi [this message]
2019-05-21  2:32 ` [spp] [PATCH 2/6] shared/sec: rename func for parsing comp name ogawa.yasufumi
2019-05-21  2:32 ` [spp] [PATCH 3/6] shared/sec: refacotr comments for parse " ogawa.yasufumi
2019-05-21  2:32 ` [spp] [PATCH 4/6] shared/sec: rename func for parsing lcore ID ogawa.yasufumi
2019-05-21  2:32 ` [spp] [PATCH 5/6] shared/sec: rename func of parsing comp type ogawa.yasufumi
2019-05-21  2:32 ` [spp] [PATCH 6/6] shared/sec: rename parsing comp action ogawa.yasufumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558405924-8303-2-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).