From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 3/6] shared/sec: refacotr comments for parse comp name
Date: Tue, 21 May 2019 11:32:01 +0900 [thread overview]
Message-ID: <1558405924-8303-4-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1558405924-8303-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
This update is to refactor comments for function for parsing component
name which is updated previous patch.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/shared/secondary/spp_worker_th/cmd_parser.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c
index e99cdeb..cf6c4a1 100644
--- a/src/shared/secondary/spp_worker_th/cmd_parser.c
+++ b/src/shared/secondary/spp_worker_th/cmd_parser.c
@@ -323,7 +323,7 @@ parse_comp_action(void *output, const char *arg_val,
return SPP_RET_OK;
}
-/* decoding procedure of action for component command */
+/* Parse given name `arg_val` of component. */
static int
parse_comp_name(void *output, const char *arg_val,
int allow_override __attribute__ ((unused)))
@@ -331,12 +331,13 @@ parse_comp_name(void *output, const char *arg_val,
int ret;
struct sppwk_cmd_comp *component = output;
- /* "stop" has no core ID parameter. */
+ /* Parsing the name is required only for action `start`. */
if (component->wk_action == SPPWK_ACT_START) {
+ /* Get lcore ID as comp name, or NG code. */
ret = spp_get_component_id(arg_val);
if (unlikely(ret >= 0)) {
RTE_LOG(ERR, SPP_COMMAND_PROC,
- "Component name in used. val=%s\n",
+ "Comp name '%s' is already used.\n",
arg_val);
return SPP_RET_NG;
}
--
2.17.1
next prev parent reply other threads:[~2019-05-21 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 2:31 [spp] [PATCH 0/6] Revise name of funcs for parsing actions ogawa.yasufumi
2019-05-21 2:31 ` [spp] [PATCH 1/6] shared/sec: rename parse comp action val ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 2/6] shared/sec: rename func for parsing comp name ogawa.yasufumi
2019-05-21 2:32 ` ogawa.yasufumi [this message]
2019-05-21 2:32 ` [spp] [PATCH 4/6] shared/sec: rename func for parsing lcore ID ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 5/6] shared/sec: rename func of parsing comp type ogawa.yasufumi
2019-05-21 2:32 ` [spp] [PATCH 6/6] shared/sec: rename parsing comp action ogawa.yasufumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558405924-8303-4-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).