From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C2E99A05D3 for ; Tue, 21 May 2019 04:34:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79E5D5589; Tue, 21 May 2019 04:34:52 +0200 (CEST) Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 590514C88 for ; Tue, 21 May 2019 04:34:50 +0200 (CEST) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x4L2Ynlb009120; Tue, 21 May 2019 11:34:49 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 4352D6387B4; Tue, 21 May 2019 11:34:49 +0900 (JST) Received: from localhost.localdomain (lobster.nslab.ecl.ntt.co.jp [129.60.13.95]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 35894638746; Tue, 21 May 2019 11:34:49 +0900 (JST) From: ogawa.yasufumi@lab.ntt.co.jp To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Date: Tue, 21 May 2019 11:32:22 +0900 Message-Id: <1558405944-8355-7-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1558405944-8355-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> References: <1558405944-8355-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-TM-AS-MML: disable Subject: [spp] [PATCH 6/8] shared/sec: rename func for parsing PCP X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa This update is to rename `decode_port_pcp()` to `parse_port_pcp()`. Signed-off-by: Yasufumi Ogawa --- src/shared/secondary/spp_worker_th/cmd_parser.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c index 0fd105c..fc30463 100644 --- a/src/shared/secondary/spp_worker_th/cmd_parser.c +++ b/src/shared/secondary/spp_worker_th/cmd_parser.c @@ -569,22 +569,23 @@ parse_port_vid(void *output, const char *arg_val, return SPP_RET_OK; } -/* decoding procedure of pcp for port command */ +/* Parse PCP for port command */ static int -decode_port_pcp(void *output, const char *arg_val, - int allow_override __attribute__ ((unused))) +parse_port_pcp(void *output, const char *arg_val, + int allow_override __attribute__ ((unused))) { - int ret = SPP_RET_OK; + int pcp; struct sppwk_cmd_port *port = output; struct spp_port_ability *ability = &port->ability; switch (ability->ops) { case SPPWK_PORT_ABL_OPS_ADD_VLANTAG: - ret = get_int_in_range(&ability->data.vlantag.pcp, + pcp = get_int_in_range(&ability->data.vlantag.pcp, arg_val, 0, SPP_VLAN_PCP_MAX); - if (unlikely(ret < SPP_RET_OK)) { + if (unlikely(pcp < SPP_RET_OK)) { RTE_LOG(ERR, SPP_COMMAND_PROC, - "Bad VLAN PCP. val=%s\n", arg_val); + "Invalid `%s`for parsing PCP.\n", + arg_val); return SPP_RET_NG; } break; @@ -863,7 +864,7 @@ cmd_ops_list[][SPPWK_MAX_PARAMS] = { { .name = "port pcp", .offset = offsetof(struct spp_command, spec.port), - .func = decode_port_pcp + .func = parse_port_pcp }, SPPWK_CMD_NO_PARAMS, }, -- 2.17.1