From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0D76EA05D3 for ; Tue, 21 May 2019 04:35:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05500A3; Tue, 21 May 2019 04:35:10 +0200 (CEST) Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 69506A3 for ; Tue, 21 May 2019 04:35:08 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x4L2Z7Gb003224; Tue, 21 May 2019 11:35:07 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 53179EA7954; Tue, 21 May 2019 11:35:07 +0900 (JST) Received: from localhost.localdomain (lobster.nslab.ecl.ntt.co.jp [129.60.13.95]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 457DFEA783F; Tue, 21 May 2019 11:35:07 +0900 (JST) From: ogawa.yasufumi@lab.ntt.co.jp To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Date: Tue, 21 May 2019 11:32:40 +0900 Message-Id: <1558405962-8406-2-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1558405962-8406-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> References: <1558405962-8406-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-TM-AS-MML: disable Subject: [spp] [PATCH 1/3] shared/sec: rename func for parsing cls table X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa This update is to rename function for parsing and getting index of action `decode_classifier_action_value()` to `parse_cls_action()`, and refactor comments and log messages. Signed-off-by: Yasufumi Ogawa --- .../secondary/spp_worker_th/cmd_parser.c | 31 +++++++++++-------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c index b043b4c..70cf254 100644 --- a/src/shared/secondary/spp_worker_th/cmd_parser.c +++ b/src/shared/secondary/spp_worker_th/cmd_parser.c @@ -621,27 +621,32 @@ parse_mac_addr(void *output, const char *arg_val, return SPP_RET_OK; } -/* decoding procedure of action for classifier_table command */ +/** + * Parse given action for getting index of actions for `classifier_table` + * command. + */ static int -decode_classifier_action_value(void *output, const char *arg_val, - int allow_override __attribute__ ((unused))) +parse_cls_action(void *output, const char *arg_val, + int allow_override __attribute__ ((unused))) { - int ret = SPP_RET_OK; - ret = get_list_idx(arg_val, CMD_ACT_LIST); - if (unlikely(ret <= 0)) { - RTE_LOG(ERR, SPP_COMMAND_PROC, "Unknown port action. val=%s\n", + int idx; + idx = get_list_idx(arg_val, CMD_ACT_LIST); + if (unlikely(idx <= 0)) { + RTE_LOG(ERR, SPP_COMMAND_PROC, + "Failed to get index for action `%s`.\n", arg_val); return SPP_RET_NG; } - if (unlikely(ret != SPPWK_ACT_ADD) && - unlikely(ret != SPPWK_ACT_DEL)) { - RTE_LOG(ERR, SPP_COMMAND_PROC, "Unknown port action. val=%s\n", + if (unlikely(idx != SPPWK_ACT_ADD) && + unlikely(idx != SPPWK_ACT_DEL)) { + RTE_LOG(ERR, SPP_COMMAND_PROC, + "Unknown action `%s` for port.\n", arg_val); return SPP_RET_NG; } - *(int *)output = ret; + *(int *)output = idx; return SPP_RET_OK; } @@ -748,7 +753,7 @@ cmd_ops_list[][SPPWK_MAX_PARAMS] = { .name = "action", .offset = offsetof(struct spp_command, spec.cls_table.wk_action), - .func = decode_classifier_action_value + .func = parse_cls_action }, { .name = "type", @@ -775,7 +780,7 @@ cmd_ops_list[][SPPWK_MAX_PARAMS] = { .name = "action", .offset = offsetof(struct spp_command, spec.cls_table.wk_action), - .func = decode_classifier_action_value + .func = parse_cls_action }, { .name = "type", -- 2.17.1