From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 28941A05D3 for ; Tue, 21 May 2019 04:35:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1ED604C96; Tue, 21 May 2019 04:35:12 +0200 (CEST) Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 7D4AE10BD for ; Tue, 21 May 2019 04:35:08 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x4L2Z7Zw009131; Tue, 21 May 2019 11:35:07 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 5F864EA7A6B; Tue, 21 May 2019 11:35:07 +0900 (JST) Received: from localhost.localdomain (lobster.nslab.ecl.ntt.co.jp [129.60.13.95]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 513D4EA7939; Tue, 21 May 2019 11:35:07 +0900 (JST) From: ogawa.yasufumi@lab.ntt.co.jp To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Date: Tue, 21 May 2019 11:32:42 +0900 Message-Id: <1558405962-8406-4-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1558405962-8406-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> References: <1558405962-8406-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> X-TM-AS-MML: disable Subject: [spp] [PATCH 3/3] shared/sec: rename func for parsing VLAN ID X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa This update is to rename function for parsing and getting VLAN ID for classifier_table command `decode_classifier_vid_value()` to `parse_cls_vid()` and refactoring. Signed-off-by: Yasufumi Ogawa --- src/shared/secondary/spp_worker_th/cmd_parser.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c index 4cd36ca..f78664b 100644 --- a/src/shared/secondary/spp_worker_th/cmd_parser.c +++ b/src/shared/secondary/spp_worker_th/cmd_parser.c @@ -668,15 +668,15 @@ parse_cls_type(void *output, const char *arg_val, return SPP_RET_OK; } -/* decoding procedure of vlan id for classifier_table command */ +/* Parse VLAN ID for classifier_table command. */ static int -decode_classifier_vid_value(void *output, const char *arg_val, - int allow_override __attribute__ ((unused))) +parse_cls_vid(void *output, const char *arg_val, + int allow_override __attribute__ ((unused))) { - int ret = SPP_RET_NG; - ret = get_int_in_range(output, arg_val, 0, ETH_VLAN_ID_MAX); - if (unlikely(ret < SPP_RET_OK)) { - RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad VLAN ID. val=%s\n", + int idx; + idx = get_int_in_range(output, arg_val, 0, ETH_VLAN_ID_MAX); + if (unlikely(idx < SPP_RET_OK)) { + RTE_LOG(ERR, SPP_COMMAND_PROC, "Invalid VLAN ID `%s`.\n", arg_val); return SPP_RET_NG; } @@ -792,7 +792,7 @@ cmd_ops_list[][SPPWK_MAX_PARAMS] = { .name = "vlan id", .offset = offsetof(struct spp_command, spec.cls_table.vid), - .func = decode_classifier_vid_value + .func = parse_cls_vid }, { .name = "mac address", -- 2.17.1