From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH] shared/sec: rename fname of command_proc
Date: Fri, 31 May 2019 12:35:45 +0900 [thread overview]
Message-ID: <1559273745-26028-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
The name of file `command_proc.c` and its header has the meaning
"to process command sent from controller", but the term `process` is
is not clear in meaning in this context because noun is usually used as
file name and `process` means a computing entity.
This update is to rename to be clear as `cmd_runner.c`, and
also its header file.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/mirror/Makefile | 2 +-
src/mirror/spp_mirror.c | 2 +-
.../spp_worker_th/{command_proc.c => cmd_runner.c} | 2 +-
.../spp_worker_th/{command_proc.h => cmd_runner.h} | 6 +++---
src/vf/Makefile | 2 +-
src/vf/spp_vf.c | 2 +-
6 files changed, 8 insertions(+), 8 deletions(-)
rename src/shared/secondary/spp_worker_th/{command_proc.c => cmd_runner.c} (99%)
rename src/shared/secondary/spp_worker_th/{command_proc.h => cmd_runner.h} (89%)
diff --git a/src/mirror/Makefile b/src/mirror/Makefile
index 3104059..07bf7ca 100644
--- a/src/mirror/Makefile
+++ b/src/mirror/Makefile
@@ -21,7 +21,7 @@ SRCS-y += $(SPP_WKT_DIR)/spp_proc.c
SRCS-y += $(SPP_WKT_DIR)/spp_port.c
SRCS-y += $(SPP_WKT_DIR)/command_conn.c
SRCS-y += $(SPP_WKT_DIR)/cmd_parser.c
-SRCS-y += $(SPP_WKT_DIR)/command_proc.c
+SRCS-y += $(SPP_WKT_DIR)/cmd_runner.c
SRCS-y += $(SPP_WKT_DIR)/string_buffer.c
SRCS-y += $(SPP_WKT_DIR)/ringlatencystats.c
diff --git a/src/mirror/spp_mirror.c b/src/mirror/spp_mirror.c
index 2e6b58a..d46d3da 100644
--- a/src/mirror/spp_mirror.c
+++ b/src/mirror/spp_mirror.c
@@ -12,7 +12,7 @@
#include "shared/secondary/spp_worker_th/mirror_deps.h"
#include "shared/common.h"
#include "shared/secondary/utils.h"
-#include "shared/secondary/spp_worker_th/command_proc.h"
+#include "shared/secondary/spp_worker_th/cmd_runner.h"
#include "shared/secondary/spp_worker_th/cmd_parser.h"
#include "shared/secondary/spp_worker_th/spp_proc.h"
#include "shared/secondary/spp_worker_th/spp_port.h"
diff --git a/src/shared/secondary/spp_worker_th/command_proc.c b/src/shared/secondary/spp_worker_th/cmd_runner.c
similarity index 99%
rename from src/shared/secondary/spp_worker_th/command_proc.c
rename to src/shared/secondary/spp_worker_th/cmd_runner.c
index 94f4142..153ea01 100644
--- a/src/shared/secondary/spp_worker_th/command_proc.c
+++ b/src/shared/secondary/spp_worker_th/cmd_runner.c
@@ -15,7 +15,7 @@
#include "command_conn.h"
#include "cmd_parser.h"
-#include "command_proc.h"
+#include "cmd_runner.h"
#define RTE_LOGTYPE_SPP_COMMAND_PROC RTE_LOGTYPE_USER1
#define RTE_LOGTYPE_APP RTE_LOGTYPE_USER2
diff --git a/src/shared/secondary/spp_worker_th/command_proc.h b/src/shared/secondary/spp_worker_th/cmd_runner.h
similarity index 89%
rename from src/shared/secondary/spp_worker_th/command_proc.h
rename to src/shared/secondary/spp_worker_th/cmd_runner.h
index 5e846a3..bccc0c5 100644
--- a/src/shared/secondary/spp_worker_th/command_proc.h
+++ b/src/shared/secondary/spp_worker_th/cmd_runner.h
@@ -2,8 +2,8 @@
* Copyright(c) 2017-2018 Nippon Telegraph and Telephone Corporation
*/
-#ifndef _COMMAND_PROC_H_
-#define _COMMAND_PROC_H_
+#ifndef _SPPWK_CMD_RUNNER_H_
+#define _SPPWK_CMD_RUNNER_H_
/**
* @file
@@ -39,4 +39,4 @@ spp_command_proc_init(const char *controller_ip, int controller_port);
int
spp_command_proc_do(void);
-#endif /* _COMMAND_PROC_H_ */
+#endif /* _SPPWK_CMD_RUNNER_H_ */
diff --git a/src/vf/Makefile b/src/vf/Makefile
index 8c1cb2b..399871f 100644
--- a/src/vf/Makefile
+++ b/src/vf/Makefile
@@ -20,7 +20,7 @@ SRCS-y += $(SPP_WKT_DIR)/ringlatencystats.c
SRCS-y += $(SPP_WKT_DIR)/spp_port.c
SRCS-y += $(SPP_WKT_DIR)/command_conn.c
SRCS-y += $(SPP_WKT_DIR)/cmd_parser.c
-SRCS-y += $(SPP_WKT_DIR)/command_proc.c
+SRCS-y += $(SPP_WKT_DIR)/cmd_runner.c
SRCS-y += $(SPP_WKT_DIR)/spp_proc.c
SRCS-y += ../shared/common.c
SRCS-y += ../shared/secondary/utils.c ../shared/secondary/add_port.c
diff --git a/src/vf/spp_vf.c b/src/vf/spp_vf.c
index 8e6e187..cbaa0c1 100644
--- a/src/vf/spp_vf.c
+++ b/src/vf/spp_vf.c
@@ -10,7 +10,7 @@
#include "spp_vf.h"
#include "classifier_mac.h"
#include "spp_forward.h"
-#include "shared/secondary/spp_worker_th/command_proc.h"
+#include "shared/secondary/spp_worker_th/cmd_runner.h"
#include "shared/secondary/spp_worker_th/cmd_parser.h"
#include "shared/secondary/spp_worker_th/spp_port.h"
--
2.17.1
reply other threads:[~2019-05-31 3:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559273745-26028-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).