From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D8FBA054F for ; Tue, 18 Feb 2020 08:42:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1296A1C1BC; Tue, 18 Feb 2020 08:42:04 +0100 (CET) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 462FA1C1BC for ; Tue, 18 Feb 2020 08:42:02 +0100 (CET) Received: by mail-pj1-f65.google.com with SMTP id r67so643500pjb.0 for ; Mon, 17 Feb 2020 23:42:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xlcLLUSDgqoOnqLcDrn0KBPziNHQYAvXSY+WlHz9jwo=; b=lM2Faoc1jQayH5vWNQa5K9x5ke1F+X1j1zbamR00i5bNNKjyzYoaR7zVqwcY5LYUXf e74+rsv4cIbN8LvK8/HhMxQJNo21FC90YNrjq440OIvegbUpkKQA/lMbJ7KFbsz/K7u4 lu17KaACJwX0ukXXuwEb2KBhdn7ygZQ/WYoFQWbi9MNOuvewdm28n5p8iQ8wVP7ACUNr WWtB4M28XQMnNap98rewuYjgtOdhlhAEETRiegpqTPKyeyS0O59Ayk/TXzFX6rxI4+IY LVfhWFjWBB5U3CDsKxpTm0RgGmWIpE7fOwTjvGZG5ASF5Ao4dozH/Oz/iPhicVHe3ewd Phzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xlcLLUSDgqoOnqLcDrn0KBPziNHQYAvXSY+WlHz9jwo=; b=VMsdXLqWY9fa7/UPl9ij2z0P48fYkre+E2tD2uKweFfdPhrtukemZJZ/HsLpGul76d rdtfxTXkq2yU0UCnGr3198wBCGKkY4SzhCvWdcxxo01Ark6OkywXTYtFkLFJheKLg6A/ +hqfPux5m/COd3G6NjlR98fJx/Xs2fv9B1/rvyuLNey5qOKutJsGhAX3yc/Qe7HTqIIb rtLbsiAFbNhK9IMRt3owu8JIDT9UmSrQx2XKfkyq4enA7LDXgVEZ0K777wqqoBTRyF9x MPgW9/buZNN2drfLMwSFpeE7u+jAmDSTUhFMPZOAZqVROLJhiH2F2Nu4wKtf+gM8bp12 1dgA== X-Gm-Message-State: APjAAAUJusMzUd0lGe0kX2XSZFvd/6P0zsjPxJwebAf+9Z8gskhRsO9L h1kLvcUlXdRJRyd+GGwtcK14POiO X-Google-Smtp-Source: APXvYqwzaYQAApMa+USiIsvQF22QRsxBgAy4JPtE9dtTMlQMT0wss2vDJFSdCP+GfVxzyNMAPO/TaA== X-Received: by 2002:a17:902:9308:: with SMTP id bc8mr20304022plb.268.1582011721296; Mon, 17 Feb 2020 23:42:01 -0800 (PST) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id z64sm3005350pfz.23.2020.02.17.23.41.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2020 23:42:00 -0800 (PST) To: x-fn-spp-ml@ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org References: <20200214091849.22194-1-x-fn-spp-ml@ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <164319b3-9ff8-4506-d586-ee3aa0420e11@gmail.com> Date: Tue, 18 Feb 2020 16:41:57 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200214091849.22194-1-x-fn-spp-ml@ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH] spp-ctl: fix exception when receiving large data X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" > From: Hideyuki Yamashita > > Upon receiving large size response, spp-ctl tries > to refer self variable which does not exist > and thus exception takes place. > This patch tries to refer Class Object instead. > > Fixes: f747dcf8 ("spp-ctl: add updating for no existing sec procs") Applied, thanks. > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Yasufumi Ogawa > --- > src/spp-ctl/spp_ctl.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spp-ctl/spp_ctl.py b/src/spp-ctl/spp_ctl.py > index ea19aa6..9e11097 100644 > --- a/src/spp-ctl/spp_ctl.py > +++ b/src/spp-ctl/spp_ctl.py > @@ -124,7 +124,7 @@ class Controller(object): > data = conn.recv(MSG_SIZE) > if data and len(data) == MSG_SIZE: > # could not receive data at once. recieve remining data. > - data += self._continue_recv(conn) > + data += Controller._continue_recv(conn) > if data: > data = data.decode() > except Exception as e: >