From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id E1C945592 for ; Thu, 28 Dec 2017 05:56:19 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id vBS4uHmu025400 for unknown; Thu, 28 Dec 2017 13:56:17 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id vBS4u5A8027247 for unknown; Thu, 28 Dec 2017 13:56:05 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id PAA27244; Thu, 28 Dec 2017 13:56:05 +0900 Received: from imss03.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u5ao010970 for unknown; Thu, 28 Dec 2017 13:56:05 +0900 Received: from mgate01.silk.ntt-tx.co.jp (smtp02.silk.ntt-tx.co.jp [10.107.0.37]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u5eY010967 for unknown; Thu, 28 Dec 2017 13:56:05 +0900 Message-Id: <201712280456.vBS4u5eY010967@imss03.silk.ntt-tx.co.jp> Received: from localhost by mgate01.silk.ntt-tx.co.jp (unknown) id vBS4u4ak025622 ; Thu, 28 Dec 2017 13:56:05 +0900 From: x-fn-spp@sl.ntt-tx.co.jp To: spp@dpdk.org Date: Thu, 28 Dec 2017 13:55:19 +0900 X-Mailer: git-send-email 1.9.1 In-Reply-To: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> References: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: No Subject: [spp] [PATCH 12/57] spp_vf: fix compiler warning in command_proc.c X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 04:56:20 -0000 From: Hiroyuki Nakamura * Fix type unmatch. * Refactor log. Signed-off-by: Daiki Yamashita Signed-off-by: Yasufum Ogawa --- src/vf/command_proc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/vf/command_proc.c b/src/vf/command_proc.c index 7a5ed56..d203857 100644 --- a/src/vf/command_proc.c +++ b/src/vf/command_proc.c @@ -540,17 +540,19 @@ decode_request(struct request *request, const char *request_str, size_t request_ /* parse json string */ top_obj = json_loadb(request_str, request_str_len, 0, &json_error); - if (unlikely(*top_obj == NULL)) { + if (unlikely(top_obj == NULL)) { RTE_LOG(ERR, SPP_COMMAND_PROC, "Cannot parse command request. " "error=%s, request_str=%.*s\n", - json_error.text, request_str_len, request_str); + json_error.text, (int)request_str_len, request_str); return -1; } /* decode request object */ ret = decode_json_object(request, top_obj, DECODERULE_REQUEST); if (unlikely(ret != 0)) { - // TODO:エラー + RTE_LOG(ERR, SPP_COMMAND_PROC, "Cannot decode command request. " + "ret=%d, request_str=%.*s\n", + ret, (int)request_str_len, request_str); return -1; } @@ -597,7 +599,7 @@ process_request(const char *request_str, size_t request_str_len) struct request request; RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Receive command request. " - "request_str=%.*s\n", request_str_len, request_str); + "request_str=%.*s\n", (int)request_str_len, request_str); memset(&request, 0, sizeof(struct request)); -- 1.9.1