From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 1C035374E for ; Thu, 28 Dec 2017 05:56:09 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id vBS4u8jE025150 for unknown; Thu, 28 Dec 2017 13:56:08 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id vBS4u7JQ027325 for unknown; Thu, 28 Dec 2017 13:56:07 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id PAA27306; Thu, 28 Dec 2017 13:56:06 +0900 Received: from imss03.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u6LG011036 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Received: from mgate01.silk.ntt-tx.co.jp (smtp02.silk.ntt-tx.co.jp [10.107.0.37]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u6A6011022 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Message-Id: <201712280456.vBS4u6A6011022@imss03.silk.ntt-tx.co.jp> Received: from localhost by mgate01.silk.ntt-tx.co.jp (unknown) id vBS4u4av025622 ; Thu, 28 Dec 2017 13:56:05 +0900 From: x-fn-spp@sl.ntt-tx.co.jp To: spp@dpdk.org Date: Thu, 28 Dec 2017 13:55:30 +0900 X-Mailer: git-send-email 1.9.1 In-Reply-To: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> References: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> X-TM-AS-MML: No Subject: [spp] [PATCH 23/57] spp_vf: display usage message X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 04:56:10 -0000 From: Hiroyuki Nakamura * When there is no required startup parameter, usage message will displayed. Signed-off-by: Kentaro Watanabe Signed-off-by: Yasufum Ogawa --- src/vf/spp_vf.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/vf/spp_vf.c b/src/vf/spp_vf.c index 6c6b832..1eaaac9 100644 --- a/src/vf/spp_vf.c +++ b/src/vf/spp_vf.c @@ -359,6 +359,8 @@ static int parse_app_args(int argc, char *argv[]) { int cnt; + int proc_flg = 0; + int server_flg = 0; int option_index, opt; const int argcopt = argc; char *argvopt[argcopt]; @@ -392,6 +394,7 @@ parse_app_args(int argc, char *argv[]) usage(progname); return -1; } + proc_flg = 1; break; case 's': if (parse_app_server(optarg, g_startup_param.server_ip, @@ -399,6 +402,7 @@ parse_app_args(int argc, char *argv[]) usage(progname); return -1; } + server_flg = 1; break; default: usage(progname); @@ -407,6 +411,11 @@ parse_app_args(int argc, char *argv[]) } } + /* Check mandatory parameters */ + if ((proc_flg == 0) || (server_flg == 0)) { + usage(progname); + return -1; + } RTE_LOG(INFO, APP, "application arguments value. (process id = %d, config = %s, server = %s:%d)\n", g_startup_param.process_id, config_file_path, -- 1.9.1