From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 0BE7F2A66 for ; Thu, 28 Dec 2017 05:56:10 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id vBS4u8ec025149 for unknown; Thu, 28 Dec 2017 13:56:08 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id vBS4u616027315 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id PAA27304; Thu, 28 Dec 2017 13:56:06 +0900 Received: from imss03.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u6n5011038 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Received: from mgate01.silk.ntt-tx.co.jp (smtp02.silk.ntt-tx.co.jp [10.107.0.37]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u6CW011019 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Message-Id: <201712280456.vBS4u6CW011019@imss03.silk.ntt-tx.co.jp> Received: from localhost by mgate01.silk.ntt-tx.co.jp (unknown) id vBS4u4as025622 ; Thu, 28 Dec 2017 13:56:05 +0900 From: x-fn-spp@sl.ntt-tx.co.jp To: spp@dpdk.org Date: Thu, 28 Dec 2017 13:55:27 +0900 X-Mailer: git-send-email 1.9.1 In-Reply-To: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> References: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> X-TM-AS-MML: No Subject: [spp] [PATCH 20/57] spp_vf: fix error in command decode X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 04:56:12 -0000 From: Hiroyuki Nakamura Fix wrong counter variable to be used. Signed-off-by: Kentaro Watanabe Signed-off-by: Yasufum Ogawa --- src/vf/command_proc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/vf/command_proc.c b/src/vf/command_proc.c index 1de43f8..bec762e 100644 --- a/src/vf/command_proc.c +++ b/src/vf/command_proc.c @@ -471,7 +471,7 @@ decode_json_object(void *output, const json_t *parent_obj, void *sub_output; for (i = 0; unlikely(! IS_END_OF_DECODE_RULE(&rules[i])); ++ i) { - rule = rules + 1; + rule = rules + i; RTE_LOG(DEBUG, SPP_COMMAND_PROC, "get one object. name=%s\n", rule->name); @@ -497,20 +497,20 @@ decode_json_object(void *output, const json_t *parent_obj, json_array_foreach(value_obj, n, obj) { RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Decode array element. " - "index=%d\n", i); + "index=%d\n", n); if (unlikely(json_typeof(obj) != rule->array.json_type)) { RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad value type. " - "name=%s, index=%d\n", rule->name, i); + "name=%s, index=%d\n", rule->name, n); return DERR_BAD_TYPE; } sub_output = DR_GET_OUTPUT(output, rule) + - (rule->array.element_sz * i); + (rule->array.element_sz * n); ret = (*rule->decode_proc)(sub_output, obj, rule); if (unlikely(ret != 0)) { RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad value. " - "name=%s, index=%d\n", rule->name, i); + "name=%s, index=%d\n", rule->name, n); return ret; } } -- 1.9.1