From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 14C5B1B022 for ; Thu, 28 Dec 2017 05:56:13 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id vBS4uCS8025259 for unknown; Thu, 28 Dec 2017 13:56:12 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id vBS4u7F2027339 for unknown; Thu, 28 Dec 2017 13:56:07 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id PAA27321; Thu, 28 Dec 2017 13:56:07 +0900 Received: from imss03.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u67q011059 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Received: from mgate01.silk.ntt-tx.co.jp (smtp02.silk.ntt-tx.co.jp [10.107.0.37]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id vBS4u6lr011025 for unknown; Thu, 28 Dec 2017 13:56:06 +0900 Message-Id: <201712280456.vBS4u6lr011025@imss03.silk.ntt-tx.co.jp> Received: from localhost by mgate01.silk.ntt-tx.co.jp (unknown) id vBS4u4ax025622 ; Thu, 28 Dec 2017 13:56:06 +0900 From: x-fn-spp@sl.ntt-tx.co.jp To: spp@dpdk.org Date: Thu, 28 Dec 2017 13:55:32 +0900 X-Mailer: git-send-email 1.9.1 In-Reply-To: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> References: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> X-TM-AS-MML: No Subject: [spp] [PATCH 25/57] spp_vf: add new log and line break X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 04:56:15 -0000 From: Hiroyuki Nakamura * Add new log of command response for better understanding. Signed-off-by: Daiki Yamashita Signed-off-by: Yasufum Ogawa --- src/vf/command_conn.c | 2 +- src/vf/command_proc.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/vf/command_conn.c b/src/vf/command_conn.c index edd4d4c..7da4eec 100644 --- a/src/vf/command_conn.c +++ b/src/vf/command_conn.c @@ -89,7 +89,6 @@ spp_receive_message(int *sock, char **strbuf) size_t rx_buf_sz = MESSAGE_BUFFER_BLOCK_SIZE; ret = recv(*sock, rx_buf, rx_buf_sz, 0); - RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Receive message. count=%d\n", ret); if (ret <= 0) { if (ret == 0) { RTE_LOG(INFO, SPP_COMMAND_PROC, @@ -108,6 +107,7 @@ spp_receive_message(int *sock, char **strbuf) return -1; } + RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Receive message. count=%d\n", ret); n_rx = ret; new_strbuf = spp_strbuf_append(*strbuf, rx_buf, n_rx); diff --git a/src/vf/command_proc.c b/src/vf/command_proc.c index 097483c..cda72be 100644 --- a/src/vf/command_proc.c +++ b/src/vf/command_proc.c @@ -256,6 +256,9 @@ send_decode_error_response(int *sock, const struct spp_command_request *request, msg = json_dumps(top_obj, JSON_INDENT(2)); json_decref(top_obj); + RTE_LOG(INFO, SPP_COMMAND_PROC, "Make command response (decode error). " + "response_str=\n%s\n", msg); + /* send response to requester */ ret = spp_send_message(sock, msg, strlen(msg)); if (unlikely(ret != 0)) { @@ -303,10 +306,13 @@ send_command_result_response(int *sock, const struct spp_command_request *reques msg = json_dumps(top_obj, JSON_INDENT(2)); json_decref(top_obj); + RTE_LOG(INFO, SPP_COMMAND_PROC, "Make command response (command result). " + "response_str=\n%s\n", msg); + /* send response to requester */ ret = spp_send_message(sock, msg, strlen(msg)); if (unlikely(ret != 0)) { - RTE_LOG(ERR, SPP_COMMAND_PROC, "Failed to send decode error response."); + RTE_LOG(ERR, SPP_COMMAND_PROC, "Failed to send command result response."); /* not return */ } @@ -329,7 +335,7 @@ process_request(int *sock, const char *request_str, size_t request_str_len) memset(command_results, 0, sizeof(command_results)); RTE_LOG(INFO, SPP_COMMAND_PROC, "Start command request processing. " - "request_str=%.*s\n", (int)request_str_len, request_str); + "request_str=\n%.*s\n", (int)request_str_len, request_str); /* decode request message */ ret = spp_command_decode_request( -- 1.9.1