Soft Patch Panel
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Cc: spp@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	nakamura.hioryuki@po.ntt-tx.co.jp
Subject: [spp] [PATCH] spp_vf: fix build
Date: Mon, 22 Jan 2018 14:25:37 +0000	[thread overview]
Message-ID: <20180122142537.20291-1-ferruh.yigit@intel.com> (raw)

build error:
...spp/src/vf/classifier_mac.c:314:5:
   error: format specifies type 'unsigned short' but the argument
          has type 'int' [-Werror,-Wformat]
	classified_data->num_pkt - n_tx, classified_data->port);
	^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...build/include/rte_log.h:316:32:
   note: expanded from macro 'RTE_LOG'
	 RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
				     ^~~~~~~~~~~

Looks like caused by integer promotion, to fix cast variable
explicityly to uint16_t.

Fixes: 11512d8b6c28 ("spp_vf: add vf functions")
Cc: nakamura.hioryuki@po.ntt-tx.co.jp

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---

Cc: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/vf/classifier_mac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/vf/classifier_mac.c b/src/vf/classifier_mac.c
index 2e502a5..760d597 100644
--- a/src/vf/classifier_mac.c
+++ b/src/vf/classifier_mac.c
@@ -311,7 +311,8 @@ transmit_packet(struct classified_data *classified_data)
 			rte_pktmbuf_free(classified_data->pkts[i]);
 		RTE_LOG(DEBUG, SPP_CLASSIFIER_MAC,
 				"drop packets(tx). num=%hu, dpdk_port=%hu\n",
-				classified_data->num_pkt - n_tx, classified_data->port);
+				(uint16_t)(classified_data->num_pkt - n_tx),
+				classified_data->port);
 	}
 
 	classified_data->num_pkt = 0;
-- 
2.14.3

             reply	other threads:[~2018-01-22 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 14:25 Ferruh Yigit [this message]
2018-01-30  3:55 ` Yasufumi Ogawa
2018-02-01 12:01   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122142537.20291-1-ferruh.yigit@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=nakamura.hioryuki@po.ntt-tx.co.jp \
    --cc=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).