From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 74A691B7A0 for ; Thu, 8 Feb 2018 07:45:07 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id w186j6D3013369; Thu, 8 Feb 2018 15:45:06 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id w186j6th025535; Thu, 8 Feb 2018 15:45:06 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id RAA25533; Thu, 8 Feb 2018 15:45:06 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by ccmail03.silk.ntt-tx.co.jp (unknown) with ESMTP id w186j5uO002128; Thu, 8 Feb 2018 15:45:05 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss06.silk.ntt-tx.co.jp (unknown) with ESMTP id w186j5Ut022896; Thu, 8 Feb 2018 15:45:05 +0900 Received: from ccmail03 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by imss06.silk.ntt-tx.co.jp (unknown) with SMTP id w186j5x8022893; Thu, 8 Feb 2018 15:45:05 +0900 Date: Thu, 08 Feb 2018 15:44:29 +0900 From: Nakamura Hioryuki In-Reply-To: <9fb4b932-bf15-2e19-b4d7-5cb19694eb9e@intel.com> References: <201712280456.vBS4u46q010906@imss03.silk.ntt-tx.co.jp> <9fb4b932-bf15-2e19-b4d7-5cb19694eb9e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.73 [ja] X-CCMail7: CC-Mail-V7.0.2-Client-Relayed Message-Id: <201802080644.w186iPtt001750@ccmail03.silk.ntt-tx.co.jp> X-TM-AS-MML: No X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server To: Ferruh Yigit Cc: spp@dpdk.org Subject: Re: [spp] [spp 02168] Re: [PATCH 02/57] spp_vf: support multi process X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 06:45:08 -0000 > On 12/28/2017 4:55 AM, x-fn-spp@sl.ntt-tx.co.jp wrote: > > From: Hiroyuki Nakamura > > > > spp_vf was only a single process so far, but spp_vf supported > > multi process. Following modification has been made. > > > > * Change naming machanism to allow hashtable on shared memory > > to be operated by multiple processes. > > * Get config file path from command line argument. > > > > And following modification has been made. > > * Modify comment. > > * Add and modify log message. > > * Add function to remove vhost socket file. > > > > Signed-off-by: Daiki Yamashita > > Signed-off-by: Yasufum Ogawa > > > Would you mind translating comments to English. It helps if code understood by > more people. All the comment of latest code on http://dpdk.org/git/apps/spp has already been translated to English. > > + > > + /* Set log level */ > > + rte_log_set_global_level(RTE_LOG_LEVEL); > > Hi Daiki, Yasufum, > > This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this > release. > > Can you please check this? We've sent a patch, [PATCH 9/9] spp_vf: change log level setting This will enable spp_vf to build on dpdk master. Thanks, -- Nakamura Hioryuki -- Nakamura Hioryuki NTTテクノクロス　フューチャーネットワーク事業部　第一事業ユニット 〒167-0043　杉並区上荻1-2-1　インテグラルタワー 14階 TEL：03-5347-8024　FAX：03-3392-2907