Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: ferruh.yigit@intel.com, spp@dpdk.org
Cc: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Subject: [spp] [PATCH 07/12] spp: fix bug for record command
Date: Tue,  6 Mar 2018 19:39:24 +0900	[thread overview]
Message-ID: <20180306103929.64809-8-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <20180306103929.64809-1-ogawa.yasufumi@lab.ntt.co.jp>

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Add entry of exit command to precmd() method to avoid be recorded.
If exit command is recorded, spp controller is terminated immediately
as log file is loaded from playback command.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/spp.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/spp.py b/src/spp.py
index 46c1613..db43ad5 100755
--- a/src/spp.py
+++ b/src/spp.py
@@ -671,7 +671,10 @@ class Shell(cmd.Cmd, object):
 
     def precmd(self, line):
         if self.recorded_file:
-            if not (('playback' in line) or ('bye' in line)):
+            if not (
+                    ('playback' in line) or
+                    ('bye' in line) or
+                    ('exit' in line)):
                 print(line, file=self.recorded_file)
         return line
 
@@ -773,8 +776,8 @@ class Shell(cmd.Cmd, object):
             return True
 
     def do_exit(self, args):
-        print('Thank you for using Soft Patch Panel')
         self.close()
+        print('Thank you for using Soft Patch Panel')
         return True
 
 
-- 
2.13.1

  parent reply	other threads:[~2018-03-06 10:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 10:39 [spp] [PATCH 00/12] Improve spp controller ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 01/12] spp: add basic commands ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 02/12] spp: add ls command ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 03/12] spp: add completion for " ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 04/12] spp: add common completion mehtod in Shell class ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 05/12] spp: fix bug of completion ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 06/12] spp: add file type support to compl_common ogawa.yasufumi
2018-03-06 10:39 ` ogawa.yasufumi [this message]
2018-03-06 10:39 ` [spp] [PATCH 08/12] spp: add completion for playback command ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 09/12] spp: add completion for record command ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 10/12] spp: add mkdir command and its completion ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 11/12] spp: refactor help messages in Shell class ogawa.yasufumi
2018-03-06 10:39 ` [spp] [PATCH 12/12] spp: refactor logger ogawa.yasufumi
2018-03-27 23:36 ` [spp] [PATCH 00/12] Improve spp controller Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306103929.64809-8-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).