From: ogawa.yasufumi@lab.ntt.co.jp
To: ferruh.yigit@intel.com, spp@dpdk.org
Cc: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Subject: [spp] [PATCH 03/13] controller: aggregate logger to spp_common.py
Date: Tue, 6 Mar 2018 19:50:45 +0900 [thread overview]
Message-ID: <20180306105055.65210-4-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <20180306105055.65210-1-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/controller/conn_thread.py | 15 +--------------
src/controller/shell.py | 15 +--------------
src/controller/spp.py | 15 +--------------
src/controller/spp_common.py | 14 ++++++++++++++
4 files changed, 17 insertions(+), 42 deletions(-)
diff --git a/src/controller/conn_thread.py b/src/controller/conn_thread.py
index 7ba3b00..1620046 100644
--- a/src/controller/conn_thread.py
+++ b/src/controller/conn_thread.py
@@ -2,23 +2,10 @@ from Queue import Queue
import select
import socket
import spp_common
+from spp_common import logger
import threading
import traceback
-# Turn true if activate logger to debug remote command.
-logger = None
-
-if logger is True:
- import logging
- logger = logging.getLogger(__name__)
- handler = logging.StreamHandler()
- handler.setLevel(logging.DEBUG)
- formatter = logging.Formatter(
- '%(asctime)s,[%(filename)s][%(name)s][%(levelname)s]%(message)s')
- handler.setFormatter(formatter)
- logger.setLevel(logging.DEBUG)
- logger.addHandler(handler)
-
class ConnectionThread(threading.Thread):
"""Manage connection between controller and secondary"""
diff --git a/src/controller/shell.py b/src/controller/shell.py
index 145cbc3..06b0012 100644
--- a/src/controller/shell.py
+++ b/src/controller/shell.py
@@ -4,22 +4,9 @@ import os
from Queue import Empty
import re
import spp_common
+from spp_common import logger
import subprocess
-# Turn true if activate logger to debug remote command.
-logger = None
-
-if logger is True:
- import logging
- logger = logging.getLogger(__name__)
- handler = logging.StreamHandler()
- handler.setLevel(logging.DEBUG)
- formatter = logging.Formatter(
- '%(asctime)s,[%(filename)s][%(name)s][%(levelname)s]%(message)s')
- handler.setFormatter(formatter)
- logger.setLevel(logging.DEBUG)
- logger.addHandler(handler)
-
class Shell(cmd.Cmd, object):
"""SPP command prompt"""
diff --git a/src/controller/spp.py b/src/controller/spp.py
index d0d7bc9..7672cc9 100644
--- a/src/controller/spp.py
+++ b/src/controller/spp.py
@@ -10,24 +10,11 @@ from shell import Shell
import socket
import SocketServer
import spp_common
+from spp_common import logger
import sys
import threading
import traceback
-# Turn true if activate logger to debug remote command.
-logger = None
-
-if logger is True:
- import logging
- logger = logging.getLogger(__name__)
- handler = logging.StreamHandler()
- handler.setLevel(logging.DEBUG)
- formatter = logging.Formatter(
- '%(asctime)s,[%(filename)s][%(name)s][%(levelname)s]%(message)s')
- handler.setFormatter(formatter)
- logger.setLevel(logging.DEBUG)
- logger.addHandler(handler)
-
class CmdRequestHandler(SocketServer.BaseRequestHandler):
"""Request handler for getting message from remote entities"""
diff --git a/src/controller/spp_common.py b/src/controller/spp_common.py
index 8c5af07..4cbfffd 100644
--- a/src/controller/spp_common.py
+++ b/src/controller/spp_common.py
@@ -1,5 +1,19 @@
from Queue import Queue
+# Turn true if activate logger to debug remote command.
+logger = None
+
+if logger is True:
+ import logging
+ logger = logging.getLogger(__name__)
+ handler = logging.StreamHandler()
+ handler.setLevel(logging.DEBUG)
+ formatter = logging.Formatter(
+ '%(asctime)s,[%(filename)s][%(name)s][%(levelname)s]%(message)s')
+ handler.setFormatter(formatter)
+ logger.setLevel(logging.DEBUG)
+ logger.addHandler(handler)
+
PRIMARY = ''
SECONDARY_LIST = []
--
2.13.1
next prev parent reply other threads:[~2018-03-06 10:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 10:50 [spp] [PATCH 00/13] Change structure of SPP controller ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 01/13] spp: move controller to sub directory ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 02/13] controller: move connection threads ogawa.yasufumi
2018-03-06 10:50 ` ogawa.yasufumi [this message]
2018-03-06 10:50 ` [spp] [PATCH 04/13] controller: add load command ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 05/13] controller: move common methods to shell_lib ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 06/13] controller: add filter for py to compl_common ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 07/13] controller: refactor shell.py ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 08/13] controller: change logger output to logfile ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 09/13] controller: add do_topo to shell.py ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 10/13] controller: add topo.py ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 11/13] controller: add topo_subgraph command ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 12/13] controller: add cat and less command ogawa.yasufumi
2018-03-06 10:50 ` [spp] [PATCH 13/13] controller: create log directory ogawa.yasufumi
2018-03-27 23:41 ` [spp] [PATCH 00/13] Change structure of SPP controller Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306105055.65210-4-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).