* [spp] [PATCH v3 0/3] docs:improvement of document under VF directory
2018-06-13 8:48 ` [spp] [PATCH v2 " x-fn-spp
@ 2018-06-15 7:51 ` x-fn-spp
2018-08-15 15:28 ` Ferruh Yigit
2018-06-15 7:51 ` [spp] [PATCH v3 1/3] docs: add how to install qemu 2.7 x-fn-spp
` (2 subsequent siblings)
3 siblings, 1 reply; 16+ messages in thread
From: x-fn-spp @ 2018-06-15 7:51 UTC (permalink / raw)
To: ferruh.yigit, ogawa.yasufumi; +Cc: spp
From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
Yasufumi-san, thanks for your comments again.
Following your comments, I revised 2nd patch.
About 1st and 3rd patch, content is the same with that of version2.
Change on 2nd patch:
Remove $SPP_HOME because it is not necessary environment
variable.
BR,
Hiroyuki
Hiroyuki Nakamura (3):
docs: add how to install qemu 2.7
docs: correct incorrect SPP git URL
docs: delete unsupported SPP VF Secondary Command
docs/guides/spp_vf/commands/secondary.rst | 102 ------------------------------
docs/guides/spp_vf/gsg/build.rst | 27 ++++++--
2 files changed, 21 insertions(+), 108 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [spp] [PATCH v3 0/3] docs:improvement of document under VF directory
2018-06-15 7:51 ` [spp] [PATCH v3 " x-fn-spp
@ 2018-08-15 15:28 ` Ferruh Yigit
0 siblings, 0 replies; 16+ messages in thread
From: Ferruh Yigit @ 2018-08-15 15:28 UTC (permalink / raw)
To: x-fn-spp, ogawa.yasufumi; +Cc: spp
On 6/15/2018 8:51 AM, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
>
> Yasufumi-san, thanks for your comments again.
> Following your comments, I revised 2nd patch.
> About 1st and 3rd patch, content is the same with that of version2.
>
> Change on 2nd patch:
> Remove $SPP_HOME because it is not necessary environment
> variable.
>
> BR,
> Hiroyuki
>
> Hiroyuki Nakamura (3):
> docs: add how to install qemu 2.7
> docs: correct incorrect SPP git URL
> docs: delete unsupported SPP VF Secondary Command
Series applied, thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [spp] [PATCH v3 1/3] docs: add how to install qemu 2.7
2018-06-13 8:48 ` [spp] [PATCH v2 " x-fn-spp
2018-06-15 7:51 ` [spp] [PATCH v3 " x-fn-spp
@ 2018-06-15 7:51 ` x-fn-spp
2018-06-15 8:33 ` Yasufumi Ogawa
2018-06-15 7:51 ` [spp] [PATCH v3 2/3] docs: correct incorrect SPP git URL x-fn-spp
2018-06-15 7:51 ` [spp] [PATCH v3 3/3] docs: delete unsupported SPP VF Secondary Command x-fn-spp
3 siblings, 1 reply; 16+ messages in thread
From: x-fn-spp @ 2018-06-15 7:51 UTC (permalink / raw)
To: ferruh.yigit, ogawa.yasufumi; +Cc: spp
From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
This commit adds instruction about how to install qemu 2.7 in case
user does not have the version of qemu.
Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
docs/guides/spp_vf/gsg/build.rst | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
index 573d6be..465484f 100644
--- a/docs/guides/spp_vf/gsg/build.rst
+++ b/docs/guides/spp_vf/gsg/build.rst
@@ -37,7 +37,7 @@ Environment
-----------
* Ubuntu 16.04
-* qemu-kvm 2.7 or later
+* qemu-kvm 2.7 or later(if you use vhost reconnect feature described in 3.2.3)
* DPDK v17.11 or later
@@ -165,7 +165,23 @@ Then, bind it with PCI_Number.
virsh setup
-----------
-``virsh`` is a command line interface that can be used to create, destroy, stop start and edit VMs and configure. After create an image file, you can setup it with ``virt-install``.
+First of all, please check version of qemu-kvm.
+
+.. code-block:: console
+
+ $ qemu-system-x86_64 --version
+
+If your system does not have qemu-kvm or the version of qemu is less than 2.7,
+then please install qemu following
+the instruction of https://wiki.qemu.org/index.php/Hosts/Linux
+to install qemu 2.7.
+You may need to install libvirt-bin,
+virtinst, bridge-utils packages via ``apt-get`` install to run ``virt-install``.
+
+
+``virsh`` is a command line interface that can be used to create, destroy,
+stop start and edit VMs and configure. After create an image file,
+you can setup it with ``virt-install``.
.. code-block:: console
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [spp] [PATCH v3 1/3] docs: add how to install qemu 2.7
2018-06-15 7:51 ` [spp] [PATCH v3 1/3] docs: add how to install qemu 2.7 x-fn-spp
@ 2018-06-15 8:33 ` Yasufumi Ogawa
0 siblings, 0 replies; 16+ messages in thread
From: Yasufumi Ogawa @ 2018-06-15 8:33 UTC (permalink / raw)
To: x-fn-spp, ferruh.yigit; +Cc: spp
On 2018/06/15 16:51, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
>
> This commit adds instruction about how to install qemu 2.7 in case
> user does not have the version of qemu.
>
Thanks. LGTM!
Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
> docs/guides/spp_vf/gsg/build.rst | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
> index 573d6be..465484f 100644
> --- a/docs/guides/spp_vf/gsg/build.rst
> +++ b/docs/guides/spp_vf/gsg/build.rst
> @@ -37,7 +37,7 @@ Environment
> -----------
>
> * Ubuntu 16.04
> -* qemu-kvm 2.7 or later
> +* qemu-kvm 2.7 or later(if you use vhost reconnect feature described in 3.2.3)
> * DPDK v17.11 or later
>
>
> @@ -165,7 +165,23 @@ Then, bind it with PCI_Number.
>
> virsh setup
> -----------
> -``virsh`` is a command line interface that can be used to create, destroy, stop start and edit VMs and configure. After create an image file, you can setup it with ``virt-install``.
> +First of all, please check version of qemu-kvm.
> +
> +.. code-block:: console
> +
> + $ qemu-system-x86_64 --version
> +
> +If your system does not have qemu-kvm or the version of qemu is less than 2.7,
> +then please install qemu following
> +the instruction of https://wiki.qemu.org/index.php/Hosts/Linux
> +to install qemu 2.7.
> +You may need to install libvirt-bin,
> +virtinst, bridge-utils packages via ``apt-get`` install to run ``virt-install``.
> +
> +
> +``virsh`` is a command line interface that can be used to create, destroy,
> +stop start and edit VMs and configure. After create an image file,
> +you can setup it with ``virt-install``.
>
> .. code-block:: console
>
>
--
Yasufumi Ogawa
NTT Network Service Systems Labs
^ permalink raw reply [flat|nested] 16+ messages in thread
* [spp] [PATCH v3 2/3] docs: correct incorrect SPP git URL
2018-06-13 8:48 ` [spp] [PATCH v2 " x-fn-spp
2018-06-15 7:51 ` [spp] [PATCH v3 " x-fn-spp
2018-06-15 7:51 ` [spp] [PATCH v3 1/3] docs: add how to install qemu 2.7 x-fn-spp
@ 2018-06-15 7:51 ` x-fn-spp
2018-06-15 8:34 ` Yasufumi Ogawa
2018-06-15 7:51 ` [spp] [PATCH v3 3/3] docs: delete unsupported SPP VF Secondary Command x-fn-spp
3 siblings, 1 reply; 16+ messages in thread
From: x-fn-spp @ 2018-06-15 7:51 UTC (permalink / raw)
To: ferruh.yigit, ogawa.yasufumi; +Cc: spp
From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
This commit correct incorrect SPP git URL.
Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
docs/guides/spp_vf/gsg/build.rst | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
index 465484f..faeb664 100644
--- a/docs/guides/spp_vf/gsg/build.rst
+++ b/docs/guides/spp_vf/gsg/build.rst
@@ -135,10 +135,9 @@ Clone SPP in any directory and compile it.
.. code-block:: console
- $ cd /path/to/spp_home/
- $ git clone https://github.com/ntt-ns/Soft-Patch-Panel.git
- export SPP_HOME=/path/to/spp_home/Soft-Patch-Panel
- $ cd $SPP_HOME
+ $ cd /path/to/any_dir
+ $ git clone http://dpdk.org/git/apps/spp
+ $ cd spp
$ make
Setup for DPDK
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [spp] [PATCH v3 2/3] docs: correct incorrect SPP git URL
2018-06-15 7:51 ` [spp] [PATCH v3 2/3] docs: correct incorrect SPP git URL x-fn-spp
@ 2018-06-15 8:34 ` Yasufumi Ogawa
0 siblings, 0 replies; 16+ messages in thread
From: Yasufumi Ogawa @ 2018-06-15 8:34 UTC (permalink / raw)
To: x-fn-spp, ferruh.yigit; +Cc: spp
On 2018/06/15 16:51, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
>
> This commit correct incorrect SPP git URL.
>
Thanks. LGTM!
Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
> docs/guides/spp_vf/gsg/build.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
> index 465484f..faeb664 100644
> --- a/docs/guides/spp_vf/gsg/build.rst
> +++ b/docs/guides/spp_vf/gsg/build.rst
> @@ -135,10 +135,9 @@ Clone SPP in any directory and compile it.
>
> .. code-block:: console
>
> - $ cd /path/to/spp_home/
> - $ git clone https://github.com/ntt-ns/Soft-Patch-Panel.git
> - export SPP_HOME=/path/to/spp_home/Soft-Patch-Panel
> - $ cd $SPP_HOME
> + $ cd /path/to/any_dir
> + $ git clone http://dpdk.org/git/apps/spp
> + $ cd spp
> $ make
>
> Setup for DPDK
>
--
Yasufumi Ogawa
NTT Network Service Systems Labs
^ permalink raw reply [flat|nested] 16+ messages in thread
* [spp] [PATCH v3 3/3] docs: delete unsupported SPP VF Secondary Command
2018-06-13 8:48 ` [spp] [PATCH v2 " x-fn-spp
` (2 preceding siblings ...)
2018-06-15 7:51 ` [spp] [PATCH v3 2/3] docs: correct incorrect SPP git URL x-fn-spp
@ 2018-06-15 7:51 ` x-fn-spp
2018-06-15 8:34 ` Yasufumi Ogawa
3 siblings, 1 reply; 16+ messages in thread
From: x-fn-spp @ 2018-06-15 7:51 UTC (permalink / raw)
To: ferruh.yigit, ogawa.yasufumi; +Cc: spp
From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
This commit delete unsupported SPP VF Secondary Command.
Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
docs/guides/spp_vf/commands/secondary.rst | 102 ------------------------------
1 file changed, 102 deletions(-)
diff --git a/docs/guides/spp_vf/commands/secondary.rst b/docs/guides/spp_vf/commands/secondary.rst
index 564e9af..19e594c 100644
--- a/docs/guides/spp_vf/commands/secondary.rst
+++ b/docs/guides/spp_vf/commands/secondary.rst
@@ -282,105 +282,3 @@ before running ``flush`` command.
.. code-block:: console
spp > sec 1;cancel
-
-
-add
----
-
-Add a PMD to the secondary with resource ID.
-
-Adding ring 0 by
-
-.. code-block:: console
-
- spp> sec 1;add ring 0
- recv:7:{addring0}
-
-Or adding vhost 0 by
-
-.. code-block:: console
-
- spp> sec 1;add vhost 0
- recv:7:{addvhost0}
-
-
-patch
-------
-
-Create a path between two ports, source and destination ports.
-Port ID is referred by status sub commnad.
-This command just creates path and does not start forwarding.
-
-.. code-block:: console
-
- spp > sec 1;patch 0 2
- recv:7:{patch02}
-
-
-forward
--------
-
-Start forwarding.
-
-.. code-block:: console
-
- spp > sec 1;forward
- recv:7:{start forwarding}
-
-Running status is changed from ``Idling`` to ``Running`` by
-executing it.
-
-.. code-block:: console
-
- spp > sec 1;status
- recv:7:{Client ID 1 Running
- 1
- port id: 0,on,PHY,outport: none
- port id: 1,on,PHY,outport: none
- }
-
-
-stop
-----
-
-Stop forwarding.
-
-.. code-block:: console
-
- spp > sec 1;stop
- recv:7:{start forwarding}
-
-Running status is changed from ``Running`` to ``Idling`` by
-executing it.
-
-.. code-block:: console
-
- spp > sec 1;status
- recv:7:{Client ID 1 Running
- 1
- port id: 0,on,PHY,outport: none
- port id: 1,on,PHY,outport: none
- }
-
-
-del
----
-
-Delete PMD added by ``add`` subcommand from the secondary.
-
-.. code-block:: console
-
- spp> sec 1;del ring 0
- recv:7:{delring0}
-
-
-exit
-----
-
-Terminate the secondary. For terminating all secondaries, use ``bye sec``
-command instead of it.
-
-.. code-block:: console
-
- spp> sec 1;exit
- recv:7:{delring0}
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [spp] [PATCH v3 3/3] docs: delete unsupported SPP VF Secondary Command
2018-06-15 7:51 ` [spp] [PATCH v3 3/3] docs: delete unsupported SPP VF Secondary Command x-fn-spp
@ 2018-06-15 8:34 ` Yasufumi Ogawa
0 siblings, 0 replies; 16+ messages in thread
From: Yasufumi Ogawa @ 2018-06-15 8:34 UTC (permalink / raw)
To: x-fn-spp, ferruh.yigit; +Cc: spp
On 2018/06/15 16:51, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
>
> This commit delete unsupported SPP VF Secondary Command.
>
Thanks. LGTM!
Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
> docs/guides/spp_vf/commands/secondary.rst | 102 ------------------------------
> 1 file changed, 102 deletions(-)
>
> diff --git a/docs/guides/spp_vf/commands/secondary.rst b/docs/guides/spp_vf/commands/secondary.rst
> index 564e9af..19e594c 100644
> --- a/docs/guides/spp_vf/commands/secondary.rst
> +++ b/docs/guides/spp_vf/commands/secondary.rst
> @@ -282,105 +282,3 @@ before running ``flush`` command.
> .. code-block:: console
>
> spp > sec 1;cancel
> -
> -
> -add
> ----
> -
> -Add a PMD to the secondary with resource ID.
> -
> -Adding ring 0 by
> -
> -.. code-block:: console
> -
> - spp> sec 1;add ring 0
> - recv:7:{addring0}
> -
> -Or adding vhost 0 by
> -
> -.. code-block:: console
> -
> - spp> sec 1;add vhost 0
> - recv:7:{addvhost0}
> -
> -
> -patch
> -------
> -
> -Create a path between two ports, source and destination ports.
> -Port ID is referred by status sub commnad.
> -This command just creates path and does not start forwarding.
> -
> -.. code-block:: console
> -
> - spp > sec 1;patch 0 2
> - recv:7:{patch02}
> -
> -
> -forward
> --------
> -
> -Start forwarding.
> -
> -.. code-block:: console
> -
> - spp > sec 1;forward
> - recv:7:{start forwarding}
> -
> -Running status is changed from ``Idling`` to ``Running`` by
> -executing it.
> -
> -.. code-block:: console
> -
> - spp > sec 1;status
> - recv:7:{Client ID 1 Running
> - 1
> - port id: 0,on,PHY,outport: none
> - port id: 1,on,PHY,outport: none
> - }
> -
> -
> -stop
> -----
> -
> -Stop forwarding.
> -
> -.. code-block:: console
> -
> - spp > sec 1;stop
> - recv:7:{start forwarding}
> -
> -Running status is changed from ``Running`` to ``Idling`` by
> -executing it.
> -
> -.. code-block:: console
> -
> - spp > sec 1;status
> - recv:7:{Client ID 1 Running
> - 1
> - port id: 0,on,PHY,outport: none
> - port id: 1,on,PHY,outport: none
> - }
> -
> -
> -del
> ----
> -
> -Delete PMD added by ``add`` subcommand from the secondary.
> -
> -.. code-block:: console
> -
> - spp> sec 1;del ring 0
> - recv:7:{delring0}
> -
> -
> -exit
> -----
> -
> -Terminate the secondary. For terminating all secondaries, use ``bye sec``
> -command instead of it.
> -
> -.. code-block:: console
> -
> - spp> sec 1;exit
> - recv:7:{delring0}
>
--
Yasufumi Ogawa
NTT Network Service Systems Labs
^ permalink raw reply [flat|nested] 16+ messages in thread