From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id CA0561B44D for ; Thu, 2 Aug 2018 10:32:31 +0200 (CEST) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id w728WSd2032349; Thu, 2 Aug 2018 17:32:28 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id w728WQOD002106; Thu, 2 Aug 2018 17:32:26 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id TAA01611; Thu, 2 Aug 2018 17:31:10 +0900 Received: from imss03.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id w728V9hX031678; Thu, 2 Aug 2018 17:31:09 +0900 Received: from mgate02.silk.ntt-tx.co.jp (smtp02.silk.ntt-tx.co.jp [10.107.0.37]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id w728V9N5031675; Thu, 2 Aug 2018 17:31:09 +0900 Message-Id: <201808020831.w728V9N5031675@imss03.silk.ntt-tx.co.jp> Received: from localhost by mgate02.silk.ntt-tx.co.jp (unknown) id w728V9u6024372 ; Thu, 2 Aug 2018 17:31:09 +0900 From: x-fn-spp@sl.ntt-tx.co.jp To: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Cc: spp@dpdk.org Date: Thu, 2 Aug 2018 17:31:09 +0900 X-Mailer: git-send-email 2.18.0 X-TM-AS-MML: No Subject: [spp] [PATCH] spp_vf: fix initializing bug of forwarder X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 08:32:32 -0000 From: Hideyuki Yamashita clear_forward_info() always initializes path[0] of g_forward_info[id]. It is a bug and causes stopping forwarding accidentally if path[0] is referenced by spp_forward(). This patch changes initializing as path[info->upd_index] instead of 0. It also includes refactoring to be simple by using local vars. Signed-off-by: Hideyuki Yamashita Signed-off-by: Naoki Takada --- src/vf/spp_forward.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vf/spp_forward.c b/src/vf/spp_forward.c index 0a43608..ee1254c 100644 --- a/src/vf/spp_forward.c +++ b/src/vf/spp_forward.c @@ -51,9 +51,9 @@ spp_forward_init(void) /* Clear info for one element. */ static void -clear_forward_info(int id) +clear_forward_info(struct forward_path *path) { - memset(&g_forward_info[id].path, 0x00, sizeof(struct forward_path)); + memset(path, 0x00, sizeof(struct forward_path)); } /* Update forward info */ @@ -84,7 +84,7 @@ spp_forward_update(struct spp_component_info *component) return -1; } - clear_forward_info(component->component_id); + clear_forward_info(path); RTE_LOG(INFO, FORWARD, "Component[%d] Start update component. (name = %s, type = %d)\n", -- 2.18.0