From: Itsuro ODA <oda@valinux.co.jp>
To: spp@dpdk.org
Subject: Re: [spp] [PATCH] spp-ctl: SPP controller with Web API
Date: Wed, 19 Sep 2018 06:40:52 +0900 [thread overview]
Message-ID: <20180919064052.2D50.277DD91C@valinux.co.jp> (raw)
In-Reply-To: <9317f709-0dc8-05fd-6b48-c265fc4da71d@lab.ntt.co.jp>
Yasufumi,
Thank you for the comment.
OK, I will revise the patch and post it again according to
your suggestion.
Thanks.
Itsuro Oda
On Tue, 18 Sep 2018 19:00:08 +0900
Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp> wrote:
> > spp-ctl is a SPP controller with a REST like web API.
> > > spp-ctl maintains the connections from the SPP processes and at
> > the same time exposes the API for the user to request for the
> > SPP processes.
> > > Background and motivation:
> > > Current CLI (spp.py/spp_vf.py) can be used by intaractive only.
> > Therefore, spp-agent, a component of networking-spp which make
> > SPP available on OpenStack environment, implements SPP controller
> > in itself. (see. https://github.com/openstack/networking-spp )
> > > Either CLI or spp-agent, there is a problem that other people can
> > not request to SPP processes while using. spp-ctl is invented to
> > solve this problem.
> > > Both CLI and spp-agent can be used spp-ctl to request SPP
> > processes instead of owning contoroller itself. In that case,
> > multiple people can request to SPP processes at the same time.
> > Note that spp-agent has a plan to change to use spp-ctl.
> > It is also available not using CLI but requesting spp-ctl
> > directly.
> Hi Itsuro,
>
> Thanks a lot for your proposal and contribution! It looks well defined APIs for existing SPP commands. I think it is also a good idea to fill the gap between usages of CLI and OpenStack.
>
> For considering our conventions, I would like to ask you to revise your patch for the reasons described below.
>
> * Patch should be divided into several patches for each of files if you add newly created files because it is difficult to understand the status of review if it is not divided.
>
> * All of documentation should be contained in `docs/guides`. Your proposal is for adding new entity and it need to create a new sub-directory. I think `docs/guides/spp-ctl` is appropriate.
>
> * `index.rst` is required in `docs/guides/spp-ctl`.
>
> * It is better to rename `README.rst` to `overview.rst` for the convention.
>
> * `requirements.txt` should not be included in `src` directory. Do you think to move it to the project root?
>
> Thanks,
> Yasufumi
--
Itsuro ODA <oda@valinux.co.jp>
next prev parent reply other threads:[~2018-09-18 21:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 23:25 Itsuro ODA
2018-09-18 10:00 ` Yasufumi Ogawa
2018-09-18 21:40 ` Itsuro ODA [this message]
2018-10-05 1:37 ` [spp] [PATCH v3 00/13] " oda
2018-10-05 1:37 ` [spp] [PATCH v3 01/13] docs: add overview of spp-ctl oda
2018-10-05 1:37 ` [spp] [PATCH v3 02/13] docs: add API reference " oda
2018-10-05 1:37 ` [spp] [PATCH v3 03/13] docs: add index " oda
2018-10-05 1:37 ` [spp] [PATCH v3 04/13] project: add requirements.txt for spp-ctl oda
2018-10-05 1:37 ` [spp] [PATCH v3 05/13] docs: add spp-ctl to index of doc root oda
2018-10-05 1:37 ` [spp] [PATCH v3 06/13] spp-ctl: add entry point oda
2018-10-05 1:37 ` [spp] [PATCH v3 07/13] spp-ctl: add Controller class oda
2018-10-05 1:37 ` [spp] [PATCH v3 08/13] spp-ctl: add web API handler oda
2018-10-05 1:37 ` [spp] [PATCH v3 09/13] spp-ctl: add spp command interfaces oda
2018-10-05 1:37 ` [spp] [PATCH v3 10/13] spp-ctl: update parsing spp_nfv status oda
2018-10-05 1:37 ` [spp] [PATCH v3 11/13] docs: add request examples of spp-ctl oda
2018-10-05 1:37 ` [spp] [PATCH v3 12/13] docs: correct directives " oda
2018-10-05 1:37 ` [spp] [PATCH v3 13/13] docs: add labels and captions for tables oda
2018-10-05 3:57 ` [spp] [PATCH v4 00/14] spp-ctl: SPP controller with Web API oda
2018-10-05 3:57 ` [spp] [PATCH v4 01/14] docs: add overview of spp-ctl oda
2018-10-05 3:57 ` [spp] [PATCH v4 02/14] docs: add API reference " oda
2018-10-05 3:57 ` [spp] [PATCH v4 03/14] docs: add index " oda
2018-10-05 3:57 ` [spp] [PATCH v4 04/14] project: add requirements.txt for spp-ctl oda
2018-10-05 3:57 ` [spp] [PATCH v4 05/14] docs: add spp-ctl to index of doc root oda
2018-10-05 3:57 ` [spp] [PATCH v4 06/14] spp-ctl: add entry point oda
2018-10-05 3:57 ` [spp] [PATCH v4 07/14] spp-ctl: add Controller class oda
2018-10-05 3:57 ` [spp] [PATCH v4 08/14] spp-ctl: add web API handler oda
2018-10-05 3:57 ` [spp] [PATCH v4 09/14] spp-ctl: add spp command interfaces oda
2018-10-05 3:57 ` [spp] [PATCH v4 10/14] spp-ctl: update parsing spp_nfv status oda
2018-10-05 3:57 ` [spp] [PATCH v4 11/14] docs: add request examples of spp-ctl oda
2018-10-05 3:57 ` [spp] [PATCH v4 12/14] docs: correct directives " oda
2018-10-05 3:57 ` [spp] [PATCH v4 13/14] docs: add labels and captions for tables oda
2018-10-05 3:57 ` [spp] [PATCH v4 14/14] spp-ctl: fix incorrect URL oda
2018-10-09 2:01 ` [spp] [PATCH v4 00/14] spp-ctl: SPP controller with Web API Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919064052.2D50.277DD91C@valinux.co.jp \
--to=oda@valinux.co.jp \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).