From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.valinux.co.jp (mail.valinux.co.jp [210.128.90.3]) by dpdk.org (Postfix) with ESMTP id B4F171041 for ; Tue, 18 Sep 2018 23:40:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.valinux.co.jp (Postfix) with ESMTP id C68D8B3AF8 for ; Wed, 19 Sep 2018 06:40:52 +0900 (JST) X-Virus-Scanned: Debian amavisd-new at valinux.co.jp Received: from mail.valinux.co.jp ([127.0.0.1]) by localhost (mail.valinux.co.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89jG7UiE-Twx for ; Wed, 19 Sep 2018 06:40:52 +0900 (JST) Received: from [127.0.0.1] (vagw.valinux.co.jp [210.128.90.14]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.valinux.co.jp (Postfix) with ESMTPS id B18DCB3AB6 for ; Wed, 19 Sep 2018 06:40:52 +0900 (JST) Date: Wed, 19 Sep 2018 06:40:52 +0900 From: Itsuro ODA To: spp@dpdk.org In-Reply-To: <9317f709-0dc8-05fd-6b48-c265fc4da71d@lab.ntt.co.jp> References: <20180913082544.2D36.277DD91C@valinux.co.jp> <9317f709-0dc8-05fd-6b48-c265fc4da71d@lab.ntt.co.jp> Message-Id: <20180919064052.2D50.277DD91C@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.71.01 [ja] Subject: Re: [spp] [PATCH] spp-ctl: SPP controller with Web API X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 21:40:55 -0000 Yasufumi, Thank you for the comment. OK, I will revise the patch and post it again according to your suggestion. Thanks. Itsuro Oda On Tue, 18 Sep 2018 19:00:08 +0900 Yasufumi Ogawa wrote: > > spp-ctl is a SPP controller with a REST like web API. > > > spp-ctl maintains the connections from the SPP processes and at > > the same time exposes the API for the user to request for the > > SPP processes. > > > Background and motivation: > > > Current CLI (spp.py/spp_vf.py) can be used by intaractive only. > > Therefore, spp-agent, a component of networking-spp which make > > SPP available on OpenStack environment, implements SPP controller > > in itself. (see. https://github.com/openstack/networking-spp ) > > > Either CLI or spp-agent, there is a problem that other people can > > not request to SPP processes while using. spp-ctl is invented to > > solve this problem. > > > Both CLI and spp-agent can be used spp-ctl to request SPP > > processes instead of owning contoroller itself. In that case, > > multiple people can request to SPP processes at the same time. > > Note that spp-agent has a plan to change to use spp-ctl. > > It is also available not using CLI but requesting spp-ctl > > directly. > Hi Itsuro, > > Thanks a lot for your proposal and contribution! It looks well defined APIs for existing SPP commands. I think it is also a good idea to fill the gap between usages of CLI and OpenStack. > > For considering our conventions, I would like to ask you to revise your patch for the reasons described below. > > * Patch should be divided into several patches for each of files if you add newly created files because it is difficult to understand the status of review if it is not divided. > > * All of documentation should be contained in `docs/guides`. Your proposal is for adding new entity and it need to create a new sub-directory. I think `docs/guides/spp-ctl` is appropriate. > > * `index.rst` is required in `docs/guides/spp-ctl`. > > * It is better to rename `README.rst` to `overview.rst` for the convention. > > * `requirements.txt` should not be included in `src` directory. Do you think to move it to the project root? > > Thanks, > Yasufumi -- Itsuro ODA