From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 1/5] shared: add error handling for invalid res UID
Date: Tue, 9 Oct 2018 19:52:03 +0900 [thread overview]
Message-ID: <20181009105207.42636-2-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <20181009105207.42636-1-ogawa.yasufumi@lab.ntt.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
There is no checking for the format of resource UID. It is caused
segmentation fault if invalid resouce UID is given to
parse_resource_uid(). This update is to add the validation and error
handling.
Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
src/shared/common.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/shared/common.c b/src/shared/common.c
index c78ee7b..bf776ee 100644
--- a/src/shared/common.c
+++ b/src/shared/common.c
@@ -228,6 +228,13 @@ parse_resource_uid(char *str, char **port_type, int *port_id)
char delim[] = ":";
char *endp;
+ RTE_LOG(DEBUG, APP, "Parsing resource UID: '%s\n'", str);
+ if (strstr(str, delim) == NULL) {
+ RTE_LOG(ERR, APP, "Invalid resource UID: '%s'\n", str);
+ return -1;
+ }
+ RTE_LOG(DEBUG, APP, "Delimiter %s is included\n", delim);
+
*port_type = strtok(str, delim);
token = strtok(NULL, delim);
--
2.7.4
next prev parent reply other threads:[~2018-10-09 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 10:52 [spp] [PATCH 0/5] Add error handling for add and del commands ogawa.yasufumi
2018-10-09 10:52 ` ogawa.yasufumi [this message]
2018-10-09 10:52 ` [spp] [PATCH 2/5] spp_nfv: add error handling for add and del cmd ogawa.yasufumi
2018-10-09 10:52 ` [spp] [PATCH 3/5] spp_vm: " ogawa.yasufumi
2018-10-09 10:52 ` [spp] [PATCH 4/5] spp_nfv: refactor add_ring_pmd ogawa.yasufumi
2018-10-09 10:52 ` [spp] [PATCH 5/5] spp_vm: " ogawa.yasufumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009105207.42636-2-ogawa.yasufumi@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).