From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bcmv-tmail01.ecl.ntt.co.jp (bcmv-tmail01.ecl.ntt.co.jp [124.146.185.148]) by dpdk.org (Postfix) with ESMTP id 755F51B466 for ; Tue, 9 Oct 2018 12:52:17 +0200 (CEST) Received: from bcmv-ns01.ecl.ntt.co.jp (bcmv-ns01.ecl.ntt.co.jp [129.60.83.123]) by bcmv-tmail01.ecl.ntt.co.jp (8.14.4/8.14.4) with ESMTP id w99AqGF0017817; Tue, 9 Oct 2018 19:52:16 +0900 Received: from bcmv-ns01.ecl.ntt.co.jp (localhost [127.0.0.1]) by bcmv-ns01.ecl.ntt.co.jp (Postfix) with ESMTP id 3E730125; Tue, 9 Oct 2018 19:52:16 +0900 (JST) Received: from localhost.localdomain (unknown [129.60.13.51]) by bcmv-ns01.ecl.ntt.co.jp (Postfix) with ESMTP id 28CAE119; Tue, 9 Oct 2018 19:52:16 +0900 (JST) From: ogawa.yasufumi@lab.ntt.co.jp To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Date: Tue, 9 Oct 2018 19:52:03 +0900 Message-Id: <20181009105207.42636-2-ogawa.yasufumi@lab.ntt.co.jp> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20181009105207.42636-1-ogawa.yasufumi@lab.ntt.co.jp> References: <20181009105207.42636-1-ogawa.yasufumi@lab.ntt.co.jp> X-TM-AS-MML: disable Subject: [spp] [PATCH 1/5] shared: add error handling for invalid res UID X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 10:52:18 -0000 From: Yasufumi Ogawa There is no checking for the format of resource UID. It is caused segmentation fault if invalid resouce UID is given to parse_resource_uid(). This update is to add the validation and error handling. Signed-off-by: Yasufumi Ogawa --- src/shared/common.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/shared/common.c b/src/shared/common.c index c78ee7b..bf776ee 100644 --- a/src/shared/common.c +++ b/src/shared/common.c @@ -228,6 +228,13 @@ parse_resource_uid(char *str, char **port_type, int *port_id) char delim[] = ":"; char *endp; + RTE_LOG(DEBUG, APP, "Parsing resource UID: '%s\n'", str); + if (strstr(str, delim) == NULL) { + RTE_LOG(ERR, APP, "Invalid resource UID: '%s'\n", str); + return -1; + } + RTE_LOG(DEBUG, APP, "Delimiter %s is included\n", delim); + *port_type = strtok(str, delim); token = strtok(NULL, delim); -- 2.7.4