Re: [spp] [PATCH] spp-ctl: update to return primary status

[Itsuro ODA <oda@valinux.co.jp>]

Hi Yasufumi,

On Tue,  9 Oct 2018 19:53:24 +0900
ogawa.yasufumi@lab.ntt.co.jp wrote:

> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> 
> Status command of primary is changed to return statistics of each of
> ports. This update is to change spp-ctl to return the reponse.
> 
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> ---
>  src/spp-ctl/spp_webapi.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spp-ctl/spp_webapi.py b/src/spp-ctl/spp_webapi.py
> index 9c16af6..dd595a0 100644
> --- a/src/spp-ctl/spp_webapi.py
> +++ b/src/spp-ctl/spp_webapi.py
> @@ -325,7 +325,6 @@ class V1NFVHandler(BaseHandler):
>          # that it has no dst port.
>          #   {"status":"idling","ports":[{"src":"phy:0","dst":"null"},...
>  
> -        # TODO(yasufum) modify after nfv and vm is updated for new data definition.
>          try:
>              nfv = json.loads(data)
>          except json.JSONDecodeError as e:
> @@ -402,7 +401,12 @@ class V1PrimaryHandler(BaseHandler):
>          # no data returned at the moment.
>          # some data will be returned when the primary becomes to
>          # return statistical information.

These comment lines should be removed at the same time because
its aim is to explain why no data returned and it is not
necessary now.

> -        return {}
> +        stat = {}
> +        try:
> +            stat = json.loads(data)
> +        except json.JSONDecodeError as e:
> +            print("%s" % e)
> +        return stat
>  
>      def get_status(self):
>          proc = self._get_proc()
> -- 
> 2.7.4

Thanks.
-- 
Itsuro ODA <oda@valinux.co.jp>