Re: [spp] [PATCH 3/4] spp-ctl: update syntax of add and del command

[Itsuro ODA <oda@valinux.co.jp>]

Hi Yasufumi,

I think it seems a bit strange to split port to if_type
and if_num before calling port_add/port_del. How about the
following fix ?

---
diff --git a/src/spp-ctl/spp_proc.py b/src/spp-ctl/spp_proc.py
index aa83b76..3b01e3f 100644
--- a/src/spp-ctl/spp_proc.py
+++ b/src/spp-ctl/spp_proc.py
@@ -145,12 +145,12 @@ class NfvProc(SppProc):
         return "status"
 
     @exec_command
-    def port_add(self, if_type, if_num):
-        return "add {if_type} {if_num}".format(**locals())
+    def port_add(self, port):
+        return "add {port}".format(**locals())
 
     @exec_command
-    def port_del(self, if_type, if_num):
-        return "del {if_type} {if_num}".format(**locals())
+    def port_del(self, port):
+        return "del {port}".format(**locals())
 
     @exec_command
     def patch_add(self, src_port, dst_port):
diff --git a/src/spp-ctl/spp_webapi.py b/src/spp-ctl/spp_webapi.py
index ddf6513..6bfc436 100644
--- a/src/spp-ctl/spp_webapi.py
+++ b/src/spp-ctl/spp_webapi.py
@@ -376,11 +376,10 @@ class V1NFVHandler(BaseHandler):
     def nfv_port(self, proc, body):
         self._validate_nfv_port(body)
 
-        if_type, if_num = body['port'].split(":")
         if body['action'] == "add":
-            proc.port_add(if_type, if_num)
+            proc.port_add(body['port'])
         else:
-            proc.port_del(if_type, if_num)
+            proc.port_del(body['port'])
 
     def _validate_nfv_patch(self, body):
         for key in ['src', 'dst']:
---

On Tue,  9 Oct 2018 19:50:46 +0900
ogawa.yasufumi@lab.ntt.co.jp wrote:

> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> 
> Because add and del command are updated to use resource UID, spp-ctl is
> also updated to use resource UID.
> 
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> ---
>  src/spp-ctl/spp_proc.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spp-ctl/spp_proc.py b/src/spp-ctl/spp_proc.py
> index aa83b76..726de3e 100644
> --- a/src/spp-ctl/spp_proc.py
> +++ b/src/spp-ctl/spp_proc.py
> @@ -146,11 +146,11 @@ class NfvProc(SppProc):
>  
>      @exec_command
>      def port_add(self, if_type, if_num):
> -        return "add {if_type} {if_num}".format(**locals())
> +        return "add {if_type}:{if_num}".format(**locals())
>  
>      @exec_command
>      def port_del(self, if_type, if_num):
> -        return "del {if_type} {if_num}".format(**locals())
> +        return "del {if_type}:{if_num}".format(**locals())
>  
>      @exec_command
>      def patch_add(self, src_port, dst_port):
> -- 
> 2.7.4

Thanks.
-- 
Itsuro ODA <oda@valinux.co.jp>