From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.valinux.co.jp (mail.valinux.co.jp [210.128.90.3]) by dpdk.org (Postfix) with ESMTP id 961191B513 for ; Tue, 9 Oct 2018 23:56:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.valinux.co.jp (Postfix) with ESMTP id CFFA9B3E08; Wed, 10 Oct 2018 06:56:01 +0900 (JST) X-Virus-Scanned: Debian amavisd-new at valinux.co.jp Received: from mail.valinux.co.jp ([127.0.0.1]) by localhost (mail.valinux.co.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jSfNJuNlEcIj; Wed, 10 Oct 2018 06:56:01 +0900 (JST) Received: from [127.0.0.1] (vagw.valinux.co.jp [210.128.90.14]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.valinux.co.jp (Postfix) with ESMTPS id BAB8DB3CED; Wed, 10 Oct 2018 06:56:01 +0900 (JST) Date: Wed, 10 Oct 2018 06:56:00 +0900 From: Itsuro ODA To: ogawa.yasufumi@lab.ntt.co.jp Cc: spp@dpdk.org, ferruh.yigit@intel.com In-Reply-To: <20181009105047.42568-4-ogawa.yasufumi@lab.ntt.co.jp> References: <20181009105047.42568-1-ogawa.yasufumi@lab.ntt.co.jp> <20181009105047.42568-4-ogawa.yasufumi@lab.ntt.co.jp> Message-Id: <20181010065600.2E02.277DD91C@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.71.01 [ja] Subject: Re: [spp] [PATCH 3/4] spp-ctl: update syntax of add and del command X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 21:56:02 -0000 Hi Yasufumi, I think it seems a bit strange to split port to if_type and if_num before calling port_add/port_del. How about the following fix ? --- diff --git a/src/spp-ctl/spp_proc.py b/src/spp-ctl/spp_proc.py index aa83b76..3b01e3f 100644 --- a/src/spp-ctl/spp_proc.py +++ b/src/spp-ctl/spp_proc.py @@ -145,12 +145,12 @@ class NfvProc(SppProc): return "status" @exec_command - def port_add(self, if_type, if_num): - return "add {if_type} {if_num}".format(**locals()) + def port_add(self, port): + return "add {port}".format(**locals()) @exec_command - def port_del(self, if_type, if_num): - return "del {if_type} {if_num}".format(**locals()) + def port_del(self, port): + return "del {port}".format(**locals()) @exec_command def patch_add(self, src_port, dst_port): diff --git a/src/spp-ctl/spp_webapi.py b/src/spp-ctl/spp_webapi.py index ddf6513..6bfc436 100644 --- a/src/spp-ctl/spp_webapi.py +++ b/src/spp-ctl/spp_webapi.py @@ -376,11 +376,10 @@ class V1NFVHandler(BaseHandler): def nfv_port(self, proc, body): self._validate_nfv_port(body) - if_type, if_num = body['port'].split(":") if body['action'] == "add": - proc.port_add(if_type, if_num) + proc.port_add(body['port']) else: - proc.port_del(if_type, if_num) + proc.port_del(body['port']) def _validate_nfv_patch(self, body): for key in ['src', 'dst']: --- On Tue, 9 Oct 2018 19:50:46 +0900 ogawa.yasufumi@lab.ntt.co.jp wrote: > From: Yasufumi Ogawa > > Because add and del command are updated to use resource UID, spp-ctl is > also updated to use resource UID. > > Signed-off-by: Yasufumi Ogawa > --- > src/spp-ctl/spp_proc.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/spp-ctl/spp_proc.py b/src/spp-ctl/spp_proc.py > index aa83b76..726de3e 100644 > --- a/src/spp-ctl/spp_proc.py > +++ b/src/spp-ctl/spp_proc.py > @@ -146,11 +146,11 @@ class NfvProc(SppProc): > > @exec_command > def port_add(self, if_type, if_num): > - return "add {if_type} {if_num}".format(**locals()) > + return "add {if_type}:{if_num}".format(**locals()) > > @exec_command > def port_del(self, if_type, if_num): > - return "del {if_type} {if_num}".format(**locals()) > + return "del {if_type}:{if_num}".format(**locals()) > > @exec_command > def patch_add(self, src_port, dst_port): > -- > 2.7.4 Thanks. -- Itsuro ODA