From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yamashita.hideyuki@po.ntt-tx.co.jp>
Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp
 [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 5BB17239
 for <spp@dpdk.org>; Tue,  6 Nov 2018 12:38:18 +0100 (CET)
Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp
 [10.107.0.111])
 by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wA6BcFEH011025;
 Tue, 6 Nov 2018 20:38:15 +0900
Received: (from root@localhost)
 by gwchk03.silk.ntt-tx.co.jp (unknown) id wA6BcFqL008314;
 Tue, 6 Nov 2018 20:38:15 +0900
Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] 
 by gwchk03.silk.ntt-tx.co.jp with ESMTP id WAA08313;
 Tue, 6 Nov 2018 20:38:15 +0900
Received: from imss05.silk.ntt-tx.co.jp (localhost [127.0.0.1])
 by ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id wA6BcFXt022353;
 Tue, 6 Nov 2018 20:38:15 +0900
Received: from imss05.silk.ntt-tx.co.jp (localhost [127.0.0.1])
 by imss05.silk.ntt-tx.co.jp (unknown) with ESMTP id wA6BcFVi027092;
 Tue, 6 Nov 2018 20:38:15 +0900
Received: from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by
 imss05.silk.ntt-tx.co.jp (unknown) with SMTP id wA6BcFq0027088;
 Tue, 6 Nov 2018 20:38:15 +0900
Date: Tue, 06 Nov 2018 20:37:16 +0900
From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
In-Reply-To: <201811061118.wA6BIk7q014743@ccmail04.silk.ntt-tx.co.jp>
References: <20180823105442.74672-1-ogawa.yasufumi@lab.ntt.co.jp>
 <201811061118.wA6BIk7q014743@ccmail04.silk.ntt-tx.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Becky! ver. 2.74 [ja]
X-CCMail7: CC-Mail-V7.0.2-Client-Relayed
Message-Id: <201811061138.wA6Bc0ZK022308@ccmail04.silk.ntt-tx.co.jp>
X-TM-AS-MML: No
X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server
To: ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org, ferruh.yigit@intel.com
Subject: [spp] Cannnot add pcap PMD and  null PMD via spp.py
X-BeenThere: spp@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Soft Patch Panel <spp.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/spp>,
 <mailto:spp-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/spp/>
List-Post: <mailto:spp@dpdk.org>
List-Help: <mailto:spp-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/spp>,
 <mailto:spp-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Nov 2018 11:38:19 -0000

Hello,

I am testing spp through spp-ctl/spp.py.

I encounter error when
- adding pcap PMD
- adding null PMD
though spp.py.

When I look source code of spp_webapi.py,
it looks type is not defined for neither null PMD or pcap PMD. 

    def _validate_port(self, port):
        try:
            if_type, if_num = port.split(":")
            if if_type not in ["phy", "vhost", "ring"]: //problematic    
                raise
            int(if_num)
        except:
            raise KeyInvalid('port', port)

It is highly appreciated that someone provide resolution on this.

Thanks in advance.

BR,
Hideyuki Yamashita
NTT TechnoCross