Soft Patch Panel
 help / color / mirror / Atom feed
From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
To: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Cc: spp@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08
Date: Wed, 07 Nov 2018 09:35:16 +0900	[thread overview]
Message-ID: <201811070036.wA70a07Z025844@ccmail04.silk.ntt-tx.co.jp> (raw)
In-Reply-To: <e42b975a-1284-d706-8d53-9f5da0899b14@lab.ntt.co.jp>

Hello Yasufumi-san,

My suggestion is to apply the first patch soon
because without that patch, compile of spp encounters error.
Soon is better.

About replacing deprecaed functions, I am planning to provide patch 
after the above mentioned patch applied to master.

BR,
Hideyuki Yamashita
NTT TechnoCross

> Hi Hideyuki,
> 
> Could you tell me what is the point of your suggestion?
> 
> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later.
> 
> Thanks,
> Yasufumi
> 
> > Hello,
> >
> > So far, it looks both patches are not merged into master branch.
> > I think change on makefile is tentative one and no need to merge.
> > But the other change on shared needs to be merged to master
> > because it is essentical change.
> >
> > BR,
> > Hideyuki Yamashita
> > NTT TechnoCross
> >
> >> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> >>
> >> Compiling SPP with DPDK v18.08 causes some of erros and warnings
> >> because of following reasons. This series of patches is to fix them.
> >>
> >> * Tx queue configuration is not updated for the new Tx offload API.
> >>
> >> * rte_eth_dev_attach/detach is deprecated but still remained.
> >>
> >> Yasufumi Ogawa (2):
> >>    shared: remove nouse txq_flags
> >>    makefile: ignore deprecated declarations
> >>
> >>   src/nfv/Makefile    | 1 +
> >>   src/shared/common.c | 1 -
> >>   src/vf/Makefile     | 1 +
> >>   src/vm/Makefile     | 1 +
> >>   4 files changed, 3 insertions(+), 1 deletion(-)
> >>
> >> --
> >> 2.7.4

  reply	other threads:[~2018-11-07  0:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 10:54 [spp] " ogawa.yasufumi
2018-08-23 10:54 ` [spp] [PATCH 1/2] shared: remove nouse txq_flags ogawa.yasufumi
2018-08-23 10:54 ` [spp] [PATCH 2/2] makefile: ignore deprecated declarations ogawa.yasufumi
2018-11-06 11:18 ` [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08 Hideyuki Yamashita
2018-11-06 11:37   ` [spp] Cannnot add pcap PMD and null PMD via spp.py Hideyuki Yamashita
2018-11-07  3:09     ` Yasufumi Ogawa
2018-11-06 12:26   ` [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08 Yasufumi Ogawa
2018-11-07  0:35     ` Hideyuki Yamashita [this message]
2018-11-07  3:03       ` Yasufumi Ogawa
2018-11-07  3:30         ` [spp] [spp 03509] " Hideyuki Yamashita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201811070036.wA70a07Z025844@ccmail04.silk.ntt-tx.co.jp \
    --to=yamashita.hideyuki@po.ntt-tx.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).