From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id AFF1C2082 for ; Wed, 7 Nov 2018 04:31:33 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wA73VWf3030597; Wed, 7 Nov 2018 12:31:32 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id wA73VWHb030304; Wed, 7 Nov 2018 12:31:32 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id NAA30303; Wed, 7 Nov 2018 12:31:32 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id wA73VVdp014173; Wed, 7 Nov 2018 12:31:31 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss06.silk.ntt-tx.co.jp (unknown) with ESMTP id wA73VVsm016873; Wed, 7 Nov 2018 12:31:31 +0900 Received: from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by imss06.silk.ntt-tx.co.jp (unknown) with SMTP id wA73VVs5016870; Wed, 7 Nov 2018 12:31:31 +0900 Date: Wed, 07 Nov 2018 12:30:30 +0900 From: Hideyuki Yamashita In-Reply-To: References: <201811070036.wA70a07Z025844@ccmail04.silk.ntt-tx.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.74 [ja] X-CCMail7: CC-Mail-V7.0.2-Client-Relayed Message-Id: <201811070331.wA73VEZA014017@ccmail04.silk.ntt-tx.co.jp> X-TM-AS-MML: No X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server To: Yasufumi Ogawa Cc: spp@dpdk.org, ferruh.yigit@intel.com Subject: Re: [spp] [spp 03509] Re: [PATCH 0/2] Fix compile error with DPDK v18.08 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 03:31:34 -0000 Hello yasufumi-san, > > Hello Yasufumi-san, > > > > My suggestion is to apply the first patch soon > > because without that patch, compile of spp encounters error. > > Soon is better. > If you compile SPP with DPDK v18.08, yes. Thanks for your confirmation. > > > > About replacing deprecaed functions, I am planning to provide patch > > after the above mentioned patch applied to master. > Could you describe about your patch if you will update to v18.08? Yes. >I think your patch is for replacing deprecated DPDK's APIs and your >patch(es) is applied even if my patch is not applied before (of course, >need both of patches for compiling). Anyway, you can send your patch >anytime for reviewing. I share the same view with you now. Then I will send my patches ASAP basis. Thanks, Hideyuki Yamashita NTT TechnoCross > Thanks, > > > > BR, > > Hideyuki Yamashita > > NTT TechnoCross > > > >> Hi Hideyuki, > >> > >> Could you tell me what is the point of your suggestion? > >> > >> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later. > >> > >> Thanks, > >> Yasufumi > >> > >>> Hello, > >>> > >>> So far, it looks both patches are not merged into master branch. > >>> I think change on makefile is tentative one and no need to merge. > >>> But the other change on shared needs to be merged to master > >>> because it is essentical change. > >>> > >>> BR, > >>> Hideyuki Yamashita > >>> NTT TechnoCross > >>> > >>>> From: Yasufumi Ogawa > >>>> > >>>> Compiling SPP with DPDK v18.08 causes some of erros and warnings > >>>> because of following reasons. This series of patches is to fix them. > >>>> > >>>> * Tx queue configuration is not updated for the new Tx offload API. > >>>> > >>>> * rte_eth_dev_attach/detach is deprecated but still remained. > >>>> > >>>> Yasufumi Ogawa (2): > >>>> shared: remove nouse txq_flags > >>>> makefile: ignore deprecated declarations > >>>> > >>>> src/nfv/Makefile | 1 + > >>>> src/shared/common.c | 1 - > >>>> src/vf/Makefile | 1 + > >>>> src/vm/Makefile | 1 + > >>>> 4 files changed, 3 insertions(+), 1 deletion(-) > >>>> > >>>> -- > >>>> 2.7.4 >