From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id CC51F4C99 for ; Fri, 9 Nov 2018 10:23:19 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wA99NHrP013920; Fri, 9 Nov 2018 18:23:18 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id wA99NHnE012089; Fri, 9 Nov 2018 18:23:17 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id UAA12088; Fri, 9 Nov 2018 18:23:17 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id wA99NHY1016954; Fri, 9 Nov 2018 18:23:17 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss06.silk.ntt-tx.co.jp (unknown) with ESMTP id wA99NHh0018332; Fri, 9 Nov 2018 18:23:17 +0900 Received: from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by imss06.silk.ntt-tx.co.jp (unknown) with SMTP id wA99NHZN018329; Fri, 9 Nov 2018 18:23:17 +0900 Date: Fri, 09 Nov 2018 18:22:08 +0900 From: Hideyuki Yamashita In-Reply-To: References: <201811070507.wA757WWo008866@imss03.silk.ntt-tx.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.74 [ja] X-CCMail7: CC-Mail-V7.0.2-Client-Relayed Message-Id: <201811090923.wA99MvqZ016850@ccmail04.silk.ntt-tx.co.jp> X-TM-AS-MML: No X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server To: Yasufumi Ogawa Cc: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com, spp@dpdk.org Subject: Re: [spp] [spp 03539] Re: [PATCH 0/6] Replace deprecated APIs X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 09:23:20 -0000 Hello Yasufumi-san, Thanks so much for your comments. About your first point, I think the follwing naming may be fit with DPDK and SPP naming conventions, what do you think? attach -> spp_eth_dev_attach detach -> spp_eth_dev_detach About your second point, I appologize about my mistake. Once I get ack for above new naming of two interfaces from you, I will revise my patch set including cover-letter and will send those to mailing list. Thanks for your co-opearation! BR, Hideyuki Yamashita NTT TechnoCorss > On 2018/11/07 14:07, x-fn-spp@sl.ntt-tx.co.jp wrote: > > From: Hideyuki Yamashita > > > >>From DPDK-18.08, the follwing APIs become deprecated and > > will be deleted in DPDK18.08. > > - rte_eth_dev_attach() > > - rte_eth_dev_detach() > > > > For rte_eth_dev_attach(), use of rte_eal_hotplug_add() is recommended. > > For rte_eth_dev_detach(), use of rte_eal_hotplug_remove() is recommended. > > > > To follow the above changes, this patch set provides replacement of > > those APIs. > Hideyuki, > > Thank you for suggesting to update to v18.08! > > Could you re-consider the name of function you added by referring conventions of DPDK and SPP? It has almost no means if just `attach` or `detach`. It is preferable to be self explanatory for how your function works. > > Commit messages are also required to be revised. Update for the change of function name and modify invalid descriptions for documentation guidelines. > > Thanks > > > > Signed-off-by: Hideyuki Yamashita > > Signed-off-by: Naoki Takada > > > > Hideyuki Yamashita (6): > > shared: addition of attach() > > spp_nfv: replacement of rte_eth_dev_attach() > > spp_vf:replacement of rte_eth_dev_attach() > > shared: addition of detach() > > spp_nfv: replacement of rte_eth_dev_detach() > > spp_vm: replacement of rte_eth_dev_detach(). > > > > src/nfv/nfv.c | 12 ++++----- > > src/shared/common.c | 64 +++++++++++++++++++++++++++++++++++++++++++++ > > src/shared/common.h | 32 +++++++++++++++++++++++ > > src/vf/spp_vf.c | 4 +-- > > src/vm/main.c | 2 +- > > 5 files changed, 105 insertions(+), 9 deletions(-) > > > > -- Yasufumi Ogawa > NTT Network Service Systems Labs >