From: x-fn-spp@sl.ntt-tx.co.jp
To: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Cc: spp@dpdk.org
Subject: [spp] [PATCH 13/23] spp_vf: define terms of commands as consts
Date: Wed, 21 Nov 2018 10:35:48 +0900 [thread overview]
Message-ID: <201811210136.wAL1a0w1009657@imss03.silk.ntt-tx.co.jp> (raw)
In-Reply-To: <20181121013558.8869-1-x-fn-spp@sl.ntt-tx.co.jp>
From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Add defines of terms of commands of spp_vf.
Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
src/vf/common/command_dec.c | 80 ++++++++++++++++++++++++++-----------
1 file changed, 56 insertions(+), 24 deletions(-)
diff --git a/src/vf/common/command_dec.c b/src/vf/common/command_dec.c
index 7cebbb5..13af984 100644
--- a/src/vf/common/command_dec.c
+++ b/src/vf/common/command_dec.c
@@ -14,14 +14,44 @@
#define RTE_LOGTYPE_SPP_COMMAND_PROC RTE_LOGTYPE_USER1
+/* command string */
+#define SPP_COMMAND_CLASSFIER_TABLE_STR "classifier_table"
+#define SPP_COMMAND_GET_CLIENT_ID_STR "_get_client_id"
+#define SPP_COMMAND_STATUS_STR "status"
+#define SPP_COMMAND_EXIT_STR "exit"
+#define SPP_COMMAND_COMPONENT_STR "component"
+#define SPP_COMMAND_PORT_STR "port"
+
+/* classifiler_type string */
+#define SPP_CLASSIFLER_NONE_STR "none"
+#define SPP_CLASSIFLER_MAC_STR "mac"
+#define SPP_CLASSIFLER_VLAN_STR "vlan"
+
+/* command action string */
+#define SPP_ACTION_NONE_STR "none"
+#define SPP_ACTION_START_STR "start"
+#define SPP_ACTION_STOP_STR "stop"
+#define SPP_ACTION_ADD_STR "add"
+#define SPP_ACTION_DEL_STR "del"
+
+/* port rx/tx string */
+#define SPP_PORT_RXTX_NONE_STR "none"
+#define SPP_PORT_RXTX_RX_STR "rx"
+#define SPP_PORT_RXTX_TX_STR "tx"
+
+/* port ability string */
+#define SPP_ABILITY_NONE_STR "none"
+#define SPP_ABILITY_ADD_VLANTAG_STR "add_vlantag"
+#define SPP_ABILITY_DEL_VLANTAG_STR "del_vlantag"
+
/*
* classifier type string list
* do it same as the order of enum spp_classifier_type (spp_vf.h)
*/
const char *CLASSIFILER_TYPE_STRINGS[] = {
- "none",
- "mac",
- "vlan",
+ SPP_CLASSIFLER_NONE_STR,
+ SPP_CLASSIFLER_MAC_STR,
+ SPP_CLASSIFLER_VLAN_STR,
/* termination */ "",
};
@@ -31,11 +61,11 @@ const char *CLASSIFILER_TYPE_STRINGS[] = {
* do it same as the order of enum spp_command_action (spp_vf.h)
*/
const char *COMMAND_ACTION_STRINGS[] = {
- "none",
- "start",
- "stop",
- "add",
- "del",
+ SPP_ACTION_NONE_STR,
+ SPP_ACTION_START_STR,
+ SPP_ACTION_STOP_STR,
+ SPP_ACTION_ADD_STR,
+ SPP_ACTION_DEL_STR,
/* termination */ "",
};
@@ -45,9 +75,9 @@ const char *COMMAND_ACTION_STRINGS[] = {
* do it same as the order of enum spp_port_rxtx (spp_vf.h)
*/
const char *PORT_RXTX_STRINGS[] = {
- "none",
- "rx",
- "tx",
+ SPP_PORT_RXTX_NONE_STR,
+ SPP_PORT_RXTX_RX_STR,
+ SPP_PORT_RXTX_TX_STR,
/* termination */ "",
};
@@ -57,9 +87,9 @@ const char *PORT_RXTX_STRINGS[] = {
* do it same as the order of enum spp_port_ability_type (spp_vf.h)
*/
const char *PORT_ABILITY_STRINGS[] = {
- "none",
- "add_vlantag",
- "del_vlantag",
+ SPP_ABILITY_NONE_STR,
+ SPP_ABILITY_ADD_VLANTAG_STR,
+ SPP_ABILITY_DEL_VLANTAG_STR,
/* termination */ "",
};
@@ -863,18 +893,20 @@ struct decode_command_list {
/* command list */
static struct decode_command_list command_list[] = {
- { "classifier_table", 5, 5, decode_command_parameter_in_list },
+ { SPP_COMMAND_CLASSFIER_TABLE_STR, 5, 5,
+ decode_command_parameter_in_list },
/* classifier_table(mac) */
- { "classifier_table", 6, 6, decode_command_parameter_in_list },
+ { SPP_COMMAND_CLASSFIER_TABLE_STR, 6, 6,
+ decode_command_parameter_in_list },
/* classifier_table(vlan) */
- { "_get_client_id", 1, 1, NULL }, /* _get_client_id */
- { "status", 1, 1, NULL }, /* status */
- { "exit", 1, 1, NULL }, /* exit */
- { "component", 3, 5, decode_command_parameter_in_list },
- /* component */
- { "port", 5, 8, decode_command_parameter_in_list },
- /* port */
- { "", 0, 0, NULL } /* termination */
+ { SPP_COMMAND_GET_CLIENT_ID_STR, 1, 1, NULL }, /* _get_client_id */
+ { SPP_COMMAND_STATUS_STR, 1, 1, NULL }, /* status */
+ { SPP_COMMAND_EXIT_STR, 1, 1, NULL }, /* exit */
+ { SPP_COMMAND_COMPONENT_STR, 3, 5,
+ decode_command_parameter_in_list }, /* component */
+ { SPP_COMMAND_PORT_STR, 5, 8,
+ decode_command_parameter_in_list }, /* port */
+ { "", 0, 0, NULL } /* termination */
};
/* Decode command line parameters */
--
2.18.0
next prev parent reply other threads:[~2018-11-21 1:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181121013558.8869-1-x-fn-spp@sl.ntt-tx.co.jp>
2018-11-21 1:35 ` [spp] [PATCH 01/23] spp_vf: fix invalid code for max chars x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 02/23] spp_vf: move common source and header files x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 03/23] spp_vf: change include path x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 04/23] spp_vf: update Makefile for common files x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 05/23] spp_vf: move functions to common directory x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 06/23] spp_vf: move defines to common dir x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 07/23] spp_vf: move functions for decode " x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 08/23] spp_vf: move defines " x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 09/23] spp_vf: move functions to command_proc.c x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 10/23] spp_vf: add management data registration x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 11/23] spp_vf: change reference of management data x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 12/23] spp_vf: change return values to explain result x-fn-spp
2018-11-21 1:35 ` x-fn-spp [this message]
2018-11-21 1:35 ` [spp] [PATCH 14/23] spp_vf: remove unnecessary includes x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 15/23] spp_vf: add include header files x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 16/23] spp_vf: update comments for header file x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 17/23] spp_vf: update makefile of spp_vf x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 18/23] spp_vf: add check num of ports before forwarding x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 19/23] spp_vf: add flag for classifier table x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 20/23] spp_vf: add checking the number of ports x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 21/23] spp_vf: add vlantag command check flag x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 22/23] spp_vf: simplify changing VLAN tag x-fn-spp
2018-11-21 1:35 ` [spp] [PATCH 23/23] spp_vf: add SPP_VF_MODULE preprocessor directive x-fn-spp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201811210136.wAL1a0w1009657@imss03.silk.ntt-tx.co.jp \
--to=x-fn-spp@sl.ntt-tx.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).