From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 153065F1F for ; Wed, 21 Nov 2018 02:41:10 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wAL1f9ll002742; Wed, 21 Nov 2018 10:41:09 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id wAL1f8Fm004636; Wed, 21 Nov 2018 10:41:08 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id LAA01900; Wed, 21 Nov 2018 10:36:02 +0900 Received: from imss03.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id wAL1a2LZ009719; Wed, 21 Nov 2018 10:36:02 +0900 Received: from mgate02.silk.ntt-tx.co.jp (smtp02.silk.ntt-tx.co.jp [10.107.0.37]) by imss03.silk.ntt-tx.co.jp (unknown) with ESMTP id wAL1a1mv009710; Wed, 21 Nov 2018 10:36:01 +0900 Message-Id: <201811210136.wAL1a1mv009710@imss03.silk.ntt-tx.co.jp> Received: from localhost by mgate02.silk.ntt-tx.co.jp (unknown) id wAL1ZwWo008346 ; Wed, 21 Nov 2018 10:36:01 +0900 From: x-fn-spp@sl.ntt-tx.co.jp To: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp Cc: spp@dpdk.org Date: Wed, 21 Nov 2018 10:35:57 +0900 X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181121013558.8869-1-x-fn-spp@sl.ntt-tx.co.jp> References: <20181121013558.8869-1-x-fn-spp@sl.ntt-tx.co.jp> X-TM-AS-MML: No Subject: [spp] [PATCH 22/23] spp_vf: simplify changing VLAN tag X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 01:41:11 -0000 From: Hideyuki Yamashita To change VLAN tag of a port, it should be deleted before and added as new one. This update is to allow to change VLAN tag at once. Signed-off-by: Hideyuki Yamashita Signed-off-by: Naoki Takada --- src/vf/common/command_proc.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/vf/common/command_proc.c b/src/vf/common/command_proc.c index 1331400..0c62968 100644 --- a/src/vf/common/command_proc.c +++ b/src/vf/common/command_proc.c @@ -337,13 +337,32 @@ spp_update_port(enum spp_command_action action, switch (action) { case SPP_CMD_ACTION_ADD: ret_check = check_port_element(port_info, *num, ports); - if (ret_check >= 0) + /* registered check */ + if (ret_check >= SPP_RET_OK) { + /* registered */ + if (ability->ope == SPP_PORT_ABILITY_OPE_ADD_VLANTAG) { + while ((cnt < SPP_PORT_ABILITY_MAX) && + (port_info->ability[cnt].ope != + SPP_PORT_ABILITY_OPE_ADD_VLANTAG)) + cnt++; + if (cnt >= SPP_PORT_ABILITY_MAX) { + RTE_LOG(ERR, APP, "update VLAN tag " + "Non-registratio\n"); + return SPP_RET_NG; + } + memcpy(&port_info->ability[cnt], ability, + sizeof(struct spp_port_ability)); + + ret = SPP_RET_OK; + break; + } return SPP_RET_OK; + } if (*num >= RTE_MAX_ETHPORTS) { RTE_LOG(ERR, APP, "Cannot assign port over the " "maximum number.\n"); - break; + return SPP_RET_NG; } if (ability->ope != SPP_PORT_ABILITY_OPE_NONE) { @@ -387,7 +406,7 @@ spp_update_port(enum spp_command_action action, break; default: - break; + return SPP_RET_NG; } *(change_component + component_id) = 1; -- 2.18.0