From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 62DCA29CB for ; Wed, 21 Nov 2018 06:16:52 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id wAL5Gosw021349; Wed, 21 Nov 2018 14:16:50 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id wAL5Goig024410; Wed, 21 Nov 2018 14:16:50 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id QAA24408; Wed, 21 Nov 2018 14:16:50 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id wAL5Gon3024435; Wed, 21 Nov 2018 14:16:50 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss06.silk.ntt-tx.co.jp (unknown) with ESMTP id wAL5Go56015738; Wed, 21 Nov 2018 14:16:50 +0900 Received: from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by imss06.silk.ntt-tx.co.jp (unknown) with SMTP id wAL5Go0f015735; Wed, 21 Nov 2018 14:16:50 +0900 Date: Wed, 21 Nov 2018 14:15:37 +0900 From: Hideyuki Yamashita In-Reply-To: References: <201811210135.wAL1ZxN9009578@imss03.silk.ntt-tx.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.74 [ja] X-CCMail7: CC-Mail-V7.0.2-Client-Relayed Message-Id: <201811210516.wAL5GWXN024298@ccmail04.silk.ntt-tx.co.jp> X-TM-AS-MML: No X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server To: Yasufumi Ogawa Cc: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com, spp@dpdk.org Subject: Re: [spp] [spp 03641] Re: [PATCH 00/23] move some codes of spp_vf into vf/common X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 05:16:53 -0000 Hello Yasufumi-san, Thanks for your asking. Please see inline. > > Some spp_vf codes can be used by new secondary process which > > is extended from spp_vf. This patch set move such codes into > > spp_vf/common. > Hi Hideyuki, > > I would like to confirm about your changes. New secondary process you mentioned is spp_mirror which is posted as the next series of patches, right? Yes. >Do you have a plan to implement secondary extended from spp_vf other >than spp_mirror? Yes. I have a plan to implement secondary extended from spp_vf other than spp_mirror. BR, Hideyuki Yamashita NTT TechnoCross > Thanks, > Yasufumi > > > > Hideyuki Yamashita (23): > > spp_vf: fix invalid code for max chars > > spp_vf: move common source and header files > > spp_vf: change include path > > spp_vf: update Makefile for common files > > spp_vf: move functions to common directory > > spp_vf: move defines to common dir > > spp_vf: move functions for decode to common dir > > spp_vf: move defines for decode to common dir > > spp_vf: move functions to command_proc.c > > spp_vf: add management data registration > > spp_vf: change reference of management data > > spp_vf: change return values to explain result > > spp_vf: define terms of commands as consts > > spp_vf: remove unnecessary includes > > spp_vf: add include header files > > spp_vf: update comments for header file > > spp_vf: update makefile of spp_vf > > spp_vf: add check num of ports before forwarding > > spp_vf: add flag for classifier table > > spp_vf: add checking the number of ports > > spp_vf: add vlantag command check flag > > spp_vf: simplify changing VLAN tag > > spp_vf: add SPP_VF_MODULE preprocessor directive > > > > src/vf/Makefile | 7 +- > > src/vf/classifier_mac.c | 139 ++- > > src/vf/classifier_mac.h | 20 +- > > src/vf/{ => common}/command_conn.c | 23 +- > > src/vf/{ => common}/command_conn.h | 16 +- > > src/vf/{ => common}/command_dec.c | 641 +++++++--- > > src/vf/{ => common}/command_dec.h | 21 +- > > src/vf/{ => common}/command_proc.c | 716 +++++++++-- > > src/vf/{ => common}/command_proc.h | 10 +- > > src/vf/{ => common}/ringlatencystats.c | 15 +- > > src/vf/{ => common}/ringlatencystats.h | 4 +- > > src/vf/{ => common}/spp_port.c | 34 +- > > src/vf/{ => common}/spp_port.h | 2 +- > > src/vf/common/spp_proc.c | 1029 ++++++++++++++++ > > src/vf/common/spp_proc.h | 727 +++++++++++ > > src/vf/{ => common}/string_buffer.c | 3 +- > > src/vf/{ => common}/string_buffer.h | 0 > > src/vf/spp_forward.c | 47 +- > > src/vf/spp_forward.h | 12 +- > > src/vf/spp_vf.c | 1574 +----------------------- > > src/vf/spp_vf.h | 511 -------- > > 21 files changed, 3074 insertions(+), 2477 deletions(-) > > rename src/vf/{ => common}/command_conn.c (90%) > > rename src/vf/{ => common}/command_conn.h (82%) > > rename src/vf/{ => common}/command_dec.c (53%) > > rename src/vf/{ => common}/command_dec.h (90%) > > rename src/vf/{ => common}/command_proc.c (63%) > > rename src/vf/{ => common}/command_proc.h (80%) > > rename src/vf/{ => common}/ringlatencystats.c (92%) > > rename src/vf/{ => common}/ringlatencystats.h (97%) > > rename src/vf/{ => common}/spp_port.c (94%) > > rename src/vf/{ => common}/spp_port.h (99%) > > create mode 100644 src/vf/common/spp_proc.c > > create mode 100644 src/vf/common/spp_proc.h > > rename src/vf/{ => common}/string_buffer.c (97%) > > rename src/vf/{ => common}/string_buffer.h (100%) > >