From: x-fn-spp@sl.ntt-tx.co.jp
To: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Cc: spp@dpdk.org
Subject: [spp] [PATCH] spp_vf: change exit command to return response
Date: Fri, 21 Dec 2018 15:23:44 +0900 [thread overview]
Message-ID: <201812210623.wBL6NiXF008245@imss03.silk.ntt-tx.co.jp> (raw)
From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
For secondary processes use common process_request(), it causes an
error because spp-ctl expects a response but these processes do not
return anything. This patch is to change it to return message.
Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
src/vf/common/command_proc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/vf/common/command_proc.c b/src/vf/common/command_proc.c
index cf35ce0..a612061 100644
--- a/src/vf/common/command_proc.c
+++ b/src/vf/common/command_proc.c
@@ -1600,8 +1600,10 @@ process_request(int *sock, const char *request_str, size_t request_str_len)
if (request.is_requested_exit) {
/* Terminated by process exit command. */
/* Other route is normal end because it responds to command. */
+ set_command_results(&command_results[0], CRES_SUCCESS, "");
+ send_command_result_response(sock, &request, command_results);
RTE_LOG(INFO, SPP_COMMAND_PROC,
- "No response with process exit command.\n");
+ "Terminate process for exit.\n");
return SPP_RET_NG;
}
--
2.17.1
next reply other threads:[~2018-12-21 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 6:23 x-fn-spp [this message]
2018-12-25 7:46 ` Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201812210623.wBL6NiXF008245@imss03.silk.ntt-tx.co.jp \
--to=x-fn-spp@sl.ntt-tx.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).