From: yasufum.o@gmail.com
To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com
Subject: [spp] [PATCH 03/10] controller: move pri help msg to SppPrimary
Date: Mon, 24 Jun 2019 16:11:17 +0900 [thread overview]
Message-ID: <20190624071124.23451-4-yasufum.o@gmail.com> (raw)
In-Reply-To: <20190624071124.23451-1-yasufum.o@gmail.com>
From: Yasufumi Ogawa <yasufum.o@gmail.com>
This patch is to move comment of `do_pri` to `SppPrimary.help` to
reduce the number of lines.
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
---
src/controller/commands/pri.py | 17 +++++++++++++++++
src/controller/shell.py | 33 +++++++--------------------------
2 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/src/controller/commands/pri.py b/src/controller/commands/pri.py
index 15bdb12..b119a5c 100644
--- a/src/controller/commands/pri.py
+++ b/src/controller/commands/pri.py
@@ -436,3 +436,20 @@ class SppPrimary(object):
pass
else:
print('Error: unknown response.')
+
+ @classmethod
+ def help(cls):
+ msg = """Send a command to primary process.
+
+ Show resources and statistics, or clear it.
+ spp > pri; status # show status
+ spp > pri; clear # clear statistics
+
+ Launch secondary process..
+ # Launch nfv:1
+ spp > pri; launch nfv 1 -l 1,2 -m 512 -- -n 1 -s 192.168....
+ # Launch vf:2
+ spp > pri; launch vf 2 -l 1,4-7 -m 512 -- --client-id 2 -s ...
+ """
+
+ print(msg)
diff --git a/src/controller/shell.py b/src/controller/shell.py
index b86ba5c..bfe963b 100644
--- a/src/controller/shell.py
+++ b/src/controller/shell.py
@@ -278,22 +278,7 @@ class Shell(cmd.Cmd, object):
self.print_status()
def do_pri(self, command):
- """Send a command to primary process.
-
- Show resources and statistics, or clear it.
-
- spp > pri; status # show status
-
- spp > pri; clear # clear statistics
-
- Launch secondary process..
-
- # Launch nfv:1
- spp > pri; launch nfv 1 -l 1,2 -m 512 -- -n 1 -s 192.168....
-
- # Launch vf:2
- spp > pri; launch vf 2 -l 1,4-7 -m 512 -- --client-id 2 -s ...
- """
+ """Send a command to primary process."""
# Remove unwanted spaces and first char ';'
command = self.clean_cmd(command)[1:]
@@ -303,6 +288,10 @@ class Shell(cmd.Cmd, object):
self.primary.run(command, self.cli_config)
+ def help_pri(self):
+ """Print help message of pri command."""
+ pri.SppPrimary.help()
+
def complete_pri(self, text, line, begidx, endidx):
"""Completion for primary process commands."""
@@ -381,15 +370,7 @@ class Shell(cmd.Cmd, object):
return res
def do_vf(self, cmd):
- """Send a command to spp_vf.
-
- spp_vf is a secondary process for pseudo SR-IOV features. This
- command has four sub commands.
- * status
- * component
- * port
- * classifier_table
- """
+ """Send a command to spp_vf."""
# remove unwanted spaces to avoid invalid command error
tmparg = self.clean_cmd(cmd)
@@ -404,7 +385,7 @@ class Shell(cmd.Cmd, object):
print('Invalid command: %s' % tmparg)
def help_vf(self):
- """Print help message of spp_vf."""
+ """Print help message of vf command."""
vf.SppVf.help()
def complete_vf(self, text, line, begidx, endidx):
--
2.17.1
next prev parent reply other threads:[~2019-06-24 7:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 7:11 [spp] [PATCH 00/10] Move help messages of CLI in shell.py yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 01/10] controller: move vf help msg to SppVf.help yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 02/10] controller: move server help msg to SppCtlServer yasufum.o
2019-06-24 7:11 ` yasufum.o [this message]
2019-06-24 7:11 ` [spp] [PATCH 04/10] controller: move nfv help msg to SppNfv yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 05/10] controller: move mirror help msg to SppMirror yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 06/10] controller: move pcap help msg to SppPcap yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 07/10] controller: move bye help msg to SppBye yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 08/10] controller: move topo " yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 09/10] controller: move status cmd help msg to help_msg yasufum.o
2019-06-24 7:11 ` [spp] [PATCH 10/10] controller: move rest of " yasufum.o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624071124.23451-4-yasufum.o@gmail.com \
--to=yasufum.o@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).