Soft Patch Panel
 help / color / mirror / Atom feed
From: yasufum.o@gmail.com
To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com
Subject: [spp] [PATCH 0/2] Remove global g_startup_param
Date: Wed, 26 Jun 2019 14:35:56 +0900	[thread overview]
Message-ID: <20190626053558.39847-1-yasufum.o@gmail.com> (raw)

From: Yasufumi Ogawa <yasufum.o@gmail.com>

This series of patches is to remove global variable of command args
`g_startup_param` because many of global variables are defined and
strongly depended on each other. It makes hard to change codes.

Instead of this global variable, each of args is retrieved with
following functions.

* get_client_id()
* get_vhost_cli_mode()
* get_spp_ctl_ip()
* get_spp_ctl_port()

Yasufumi Ogawa (2):
  shared/sec: remove global var g_startup_param
  spp_pcap: remove global var g_startup_param

 src/mirror/mir_cmd_runner.c                       | 12 ++++++------
 src/mirror/spp_mirror.c                           | 14 ++++----------
 src/pcap/cmd_runner.c                             |  8 +++-----
 src/pcap/cmd_utils.c                              | 13 +++----------
 src/pcap/cmd_utils.h                              | 15 ++-------------
 src/pcap/spp_pcap.c                               | 15 +++------------
 .../secondary/spp_worker_th/cmd_res_formatter.c   |  3 +--
 src/shared/secondary/spp_worker_th/cmd_runner.c   |  4 ++--
 src/shared/secondary/spp_worker_th/cmd_utils.c    |  9 +--------
 src/shared/secondary/spp_worker_th/cmd_utils.h    | 14 ++------------
 src/vf/spp_vf.c                                   |  8 +-------
 src/vf/vf_cmd_runner.c                            | 12 ++++++------
 12 files changed, 34 insertions(+), 93 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-06-26  5:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  5:35 yasufum.o [this message]
2019-06-26  5:35 ` [spp] [PATCH 1/2] shared/sec: remove global var g_startup_param yasufum.o
2019-06-26  5:35 ` [spp] [PATCH 2/2] spp_pcap: " yasufum.o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626053558.39847-1-yasufum.o@gmail.com \
    --to=yasufum.o@gmail.com \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).