From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2A71FA046B for ; Wed, 26 Jun 2019 07:37:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 234891B464; Wed, 26 Jun 2019 07:37:18 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 0E3334F98 for ; Wed, 26 Jun 2019 07:37:16 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id w10so630417pgj.7 for ; Tue, 25 Jun 2019 22:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=rvsRPLRWHolNK/KzBw425fn5Jz0JTpMOZT9feoMc2pQ=; b=GPUHtEcltwm0rmBxWvi6dsxAQx1nGJb/eyhXwJbfS4RlmmprhS+cjLEJXAs25P6nsW t4ivzcRvqvrUUppjiKSjbOHb6cKhp09e8YeJ2fvlDsfYX3pMlZmgs6V8X7PN4qa066rN xgV5Ay7ewT29l6r7W0fB0kmuWlbdsu7pMQ5SoiFD5jn8bwuCDRdprFGh6AT0Y7b5cZv7 Vq8m3su5pUeNDAUY8N226IoU5MMCnqng5U3l20e2dnBTCwrBKAq9itklqQhm0eoM5bkq 0DQ/ejo8KI6qP+2NcwJ94o8wla4jzeeeKaOtcWsg7iARRcDRdE7GwlPUXxHRGEMKVXm1 xIrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=rvsRPLRWHolNK/KzBw425fn5Jz0JTpMOZT9feoMc2pQ=; b=CYcMqxfpEjzfHTzw1vXHBOoJhR/yvJzoo2q6POuWEvnDkUkhPxDp22nvIAXPG4HL3i AMx753SBqZpZiuZkKBS9L6fJOUBwXaT4azeT1YqmJU028nWoo+PwNDpj3ZnnMNh/wh+7 MsH270oX4Q7Y06RgixT+F9CnA3WOrZqBdVWI541fVTA2hYjziAgNnVpEgaJlZ5r5EBnm ebKuwKI13b185LyG5LdLr6QWGAhVH1QfYGk7+u7nhUXttopCgH9t2hALDcWsLsLAOhtG nAN8jRs2a6+G5ajsynbnOknJ7AnmFNkNZoRTMgIVeuPXNdJ77DpNZOp21FSmy7K9nIJI RIpw== X-Gm-Message-State: APjAAAWxU/aezoxHRJ0WcC4AFzkcCJeP6zn3LCXCOldgI1VFcbu0Yqa6 DpT54dC7mFioII2OnS0fQ6mFUBgz X-Google-Smtp-Source: APXvYqz+gtNAQMh676HdrwYo13pCAwLEODMGV3NCA/m8O3sGNrbrQHn8oz2de63wK+W+xSRfB/Vtfw== X-Received: by 2002:a63:d415:: with SMTP id a21mr1018940pgh.229.1561527435115; Tue, 25 Jun 2019 22:37:15 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id o32sm736340pje.9.2019.06.25.22.37.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 22:37:14 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Wed, 26 Jun 2019 14:37:11 +0900 Message-Id: <20190626053711.40135-1-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [spp] [PATCH] controller: support multi socks to suggest lcores X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa Lcore suggestion of SPP CLI does not care about layout of sockets, so it possibly suggest a set of lcores on different sockets each other. For considering optimization, it should be aware of the layout for suggesting lcores on the same socket. This update is to select lcores from the same socket if possible. Signed-off-by: Yasufumi Ogawa --- src/controller/commands/pri.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/controller/commands/pri.py b/src/controller/commands/pri.py index 654b7dd..eaf3d09 100644 --- a/src/controller/commands/pri.py +++ b/src/controller/commands/pri.py @@ -159,13 +159,14 @@ class SppPrimary(object): """Get lcore usage from spp-ctl for making launch options. Return value is a double dimension list of unsed lcores. - [[2,3,...], [16,17,...]] + [[0, 2, 4, ...], [1, 3, 5, ...]] To get the result, get CPU layout as an list first, then remove used lcores from the list. """ sockets = [] # A set of CPU sockets. + # Get list of CPU layout res = self.spp_ctl_cli.get('cpu_layout') if res is not None: @@ -173,13 +174,14 @@ class SppPrimary(object): try: # Get layout of each of sockets as an array. # [[0,1,2,3,..., 15], [16,17,18],...]] - socket = [] for sock in res.json(): + socket = [] for ent in sock['cores']: socket.append(ent['lcores']) - socket.sort() - socket = sum(socket, []) - sockets.append(socket) + + socket = sum(socket, []) + socket.sort() + sockets.append(socket) except KeyError as e: print('Error: {} is not defined!'.format(e)) -- 2.17.1