From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69F7EA0487 for ; Wed, 3 Jul 2019 10:38:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FB99F04; Wed, 3 Jul 2019 10:38:02 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6C665F04 for ; Wed, 3 Jul 2019 10:38:01 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id k8so846067plt.3 for ; Wed, 03 Jul 2019 01:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=prEwQwD+pDR4FonlH31AQhla4BlPkiF7nfhlWEtVkJY=; b=Eu9bLz2malQ473MS787lsL7PC/syc1/xxAT4EUnY+uSc5Xt+KSqpn13o2M79a6nIxW M6FVwV+kpetLmXDKI2UNcgTaOoHSu027wmdjoX3gkZbJ8szCyfUs2+A95pOrEKKsTaRd eKPPNpe4sJMVdTVsSXlBZ5i6UNLD2DwZrmVP/ECrC+C2XPhnJ7FuzetWy2niLbEc25zJ MrNWq5ZxUHaYWCF/B8ruC7XPuyh4vIiSq60B49QhHey7nTOelI62r7KswFL/03Pe5kwz dM/ksjV6s7CUqWZDE5wrvafTAu2OCOVY0tnoAFQWeWlQ7AT0/X/wqWbeD5M1LAin/cqf 5wtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=prEwQwD+pDR4FonlH31AQhla4BlPkiF7nfhlWEtVkJY=; b=cmCqJMfMys8j7fg38W+KHX+QSGczuDjtyMsh5+TlWdbbSYIh7p9enPVVXAaEBDWUJE b7vi2Gd+1o4BSinoyr5jCfi11f9z6Iq6wthY70Wb7xOCqhjKX3fH9/wzE3PgvcnD/kLs gnXtXuf3A2NW2mVAjAnaNPZKKy7pm44ukSPzZHWdd02qrF7UF11CTU1uRO/Wwq5UpiXK V25aaPT1w5I4xeS6F8tioANlXWJBTXFn9N/nS5XK6MK0KEUbjm4/V41fi2XIizLNSrZT 4Ix9RWmVvLy2Zy0GSF3MbwfR3WLAMT1vJkMw11yBp85D/zopM2jLQm+H4VT6GuG4ddVb wg5A== X-Gm-Message-State: APjAAAWdOWFpugWK5XpQlamE5Pay/BO87flQsLdV7J1OW/SdXSEzDcRT B9Z+JylO/09WVVnvMeFMpNWY7S4M X-Google-Smtp-Source: APXvYqweZYvCiCpz0FbvqCrNbQMIGI/5PHy1W0XPxqoj3O32TLs8RNkNK+4PapqgmnsRsrN4V6MBHQ== X-Received: by 2002:a17:902:fa2:: with SMTP id 31mr41764628plz.38.1562143080591; Wed, 03 Jul 2019 01:38:00 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id w4sm1445825pfw.97.2019.07.03.01.37.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jul 2019 01:38:00 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Wed, 3 Jul 2019 17:37:56 +0900 Message-Id: <20190703083756.1503-1-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [spp] [PATCH] spp_vf: initialize variable master_lcore X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa Compilation of spp_vf is failed because of uninitialization of `master_lcore` variable if using optimize option. This patch is to fix the issue not only spp_vf but also spp_mirror and spp_pcap. Signed-off-by: Yasufumi Ogawa --- src/mirror/spp_mirror.c | 8 ++++++-- src/pcap/spp_pcap.c | 7 ++++++- src/vf/spp_vf.c | 7 ++++++- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/mirror/spp_mirror.c b/src/mirror/spp_mirror.c index e6352cf..b57dd57 100644 --- a/src/mirror/spp_mirror.c +++ b/src/mirror/spp_mirror.c @@ -505,6 +505,12 @@ main(int argc, char *argv[]) signal(SIGTERM, stop_process); signal(SIGINT, stop_process); + /** + * It should be initialized outside of while loop, or failed to + * compile because it is referred when finalize `g_core_info`. + */ + master_lcore = rte_get_master_lcore(); + while (1) { int ret_dpdk = rte_eal_init(argc, argv); if (unlikely(ret_dpdk < 0)) @@ -518,8 +524,6 @@ main(int argc, char *argv[]) if (unlikely(ret_parse != 0)) break; - master_lcore = rte_get_master_lcore(); - if (sppwk_set_mng_data(&g_iface_info, g_component_info, g_core_info, g_change_core, g_change_component, diff --git a/src/pcap/spp_pcap.c b/src/pcap/spp_pcap.c index 79d155c..e8b2724 100644 --- a/src/pcap/spp_pcap.c +++ b/src/pcap/spp_pcap.c @@ -927,6 +927,12 @@ main(int argc, char *argv[]) signal(SIGTERM, stop_process); signal(SIGINT, stop_process); + /** + * It should be initialized outside of while loop, or failed to + * compile because it is referred when finalize `g_core_info`. + */ + master_lcore = rte_get_master_lcore(); + while (1) { int ret_eal = rte_eal_init(argc, argv); if (unlikely(ret_eal < 0)) @@ -1032,7 +1038,6 @@ main(int argc, char *argv[]) } /* Set the status of main thread to idle */ - master_lcore = rte_get_master_lcore(); g_core_info[master_lcore].status = SPPWK_LCORE_IDLING; int ret_wait = check_core_status_wait(SPPWK_LCORE_IDLING); if (unlikely(ret_wait != 0)) diff --git a/src/vf/spp_vf.c b/src/vf/spp_vf.c index d7dd5d0..415d790 100644 --- a/src/vf/spp_vf.c +++ b/src/vf/spp_vf.c @@ -220,6 +220,12 @@ main(int argc, char *argv[]) signal(SIGTERM, stop_process); signal(SIGINT, stop_process); + /** + * It should be initialized outside of while loop, or failed to + * compile because it is referred when finalize `g_core_info`. + */ + master_lcore = rte_get_master_lcore(); + while (1) { int ret_dpdk = rte_eal_init(argc, argv); if (unlikely(ret_dpdk < 0)) @@ -274,7 +280,6 @@ main(int argc, char *argv[]) } /* Set the status of main thread to idle */ - master_lcore = rte_get_master_lcore(); g_core_info[master_lcore].status = SPPWK_LCORE_IDLING; int ret_wait = check_core_status_wait(SPPWK_LCORE_IDLING); if (unlikely(ret_wait != SPP_RET_OK)) -- 2.17.1