From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42260A0471 for ; Thu, 18 Jul 2019 07:01:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 362BA2082; Thu, 18 Jul 2019 07:01:29 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id C752B1D9E for ; Thu, 18 Jul 2019 07:01:25 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id c2so13168597plz.13 for ; Wed, 17 Jul 2019 22:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=Bktt0BlkFes6n+jyrHZ4wPv0frTmwlh9HbFZ0zztMGY=; b=B1IlKOA4ebx6UPHvGriidsfPjXA9fi2cdrAt9umMN97hRAYWGP6MCl+hoTuZg7cscK vKC0dzZN1DXwcGsglvQjrAzYFO6hp3TsS/s/KyQclgAREjU2g4v0VZbab63UzVKiYfhi P/fb+LWzyXrYFlikFjE+3hFZRAzooyp0Q0EGs+GvKheQ4DvJ0AATpL6mgO0OvDwr1Roc +Y2c9IlmNBNw0SU0NFR+9llK+WTrSqqwqrEkNLPkKFZOcI30O/trM+nQ8gB3CA1xxbZ7 20+BwSKhm8A+2f14EE8Oel5lbTgsn0KBahzFsNuHNnVS7gytRP51wWil8+PHBCHXac9S SFMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Bktt0BlkFes6n+jyrHZ4wPv0frTmwlh9HbFZ0zztMGY=; b=PD5rp0Cq0lw8vqrTriYOG/kVQfNq4LgtXczLncjR+nEKergOTS8wLF6yRIlXVSIQPN widIfuy+QJiZmxRg1Yl2EZj2kkwnBDwpHnNN96+ixdHsp0ZmygeD0EdREbMuOybrnEeH WurKDAqQW9EWgWLpP2QfvtFiyl9R5XlOn4Fv1nnRLyF1nv634+ghHLsXBuDqgSYC0kp/ 3L7uhzMpoDwxfqhuoQY4oOXlomOOP91hRFsFSigzHG9El0HsdRriquR+c2Zl5YWjyAql +DO3dK7EEzZFG1AweeS5x6OqXVpfSg0V6Ze6jNxS9wCgdEKylSXTDQqw4p/sHQvvFuTS U2fw== X-Gm-Message-State: APjAAAV1N4NfsljfByy0XCHHp/joEY4o3Fv5hxmqhsEgwknJ9Wn+nxkX dMoNRrX3bIJ9avWApCCIbQv1cXgA X-Google-Smtp-Source: APXvYqxy00ai3Ob5dDS13foFs8aQ3e91PwLqLLbIvmF+pT43Xt7bj0ev0aPRCMdXchN77NfCbraXKw== X-Received: by 2002:a17:902:be12:: with SMTP id r18mr45444137pls.341.1563426084944; Wed, 17 Jul 2019 22:01:24 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id k25sm18958372pgt.53.2019.07.17.22.01.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jul 2019 22:01:24 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Thu, 18 Jul 2019 14:01:17 +0900 Message-Id: <20190718050119.6822-2-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190718050119.6822-1-yasufum.o@gmail.com> References: <20190718050119.6822-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 1/3] spp_vf: fix wrong master lcore other than 0 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa Master lcore of spp_vf is always set as 0 and cannot to others. It is because rte_get_master_lcore() returns 0 if it is called before rte_eal_init(). This update is to move rte_eal_init() before. Fixes: 310c51b918e9 ("spp_vf: initialize variable master_lcore") Signed-off-by: Yasufumi Ogawa --- src/vf/spp_vf.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/vf/spp_vf.c b/src/vf/spp_vf.c index e2711d1..bc2a403 100644 --- a/src/vf/spp_vf.c +++ b/src/vf/spp_vf.c @@ -199,7 +199,7 @@ slave_main(void *arg __attribute__ ((unused))) int main(int argc, char *argv[]) { - int ret = SPP_RET_NG; + int ret; char ctl_ip[IPADDR_LEN] = { 0 }; int ctl_port; int ret_cmd_init; @@ -220,20 +220,24 @@ main(int argc, char *argv[]) signal(SIGTERM, stop_process); signal(SIGINT, stop_process); + ret = rte_eal_init(argc, argv); + if (unlikely(ret < 0)) + rte_exit(EXIT_FAILURE, "Invalid EAL arguments.\n"); + + argc -= ret; + argv += ret; + /** * It should be initialized outside of while loop, or failed to * compile because it is referred when finalize `g_core_info`. */ master_lcore = rte_get_master_lcore(); + /** + * If any failure is occured in the while block, break to go the end + * of the block to finalize. + */ while (1) { - int ret_dpdk = rte_eal_init(argc, argv); - if (unlikely(ret_dpdk < 0)) - break; - - argc -= ret_dpdk; - argv += ret_dpdk; - /* Parse spp_vf specific parameters */ int ret_parse = parse_app_args(argc, argv); if (unlikely(ret_parse != SPP_RET_OK)) -- 2.17.1